Also track when the error happened
Stat
Open
SendFile
Link
MakeDir
GetXattr
SetXattr
RemoveFile
RemoveLink
RemoveDir

 Issue 719762  has been merged into this issue.

(coping labels from the duped bug)

taking over

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79bbe188072ccc354d722cfb192d78b834aa27ff

commit 79bbe188072ccc354d722cfb192d78b834aa27ff
Author: kinaba <kinaba@chromium.org>
Date: Tue May 09 08:08:48 2017

cryptohome: Make the error bucket of migration UMA more detailed.

BUG= 719318 

Review-Url: https://codereview.chromium.org/2865113004
Cr-Commit-Position: refs/heads/master@{#470265}

[modify] https://crrev.com/79bbe188072ccc354d722cfb192d78b834aa27ff/tools/metrics/histograms/enums.xml

Status:
One more CL (for ChromeOS) is coming, but blocked by the completely red tree.
https://chromium-review.googlesource.com/#/c/500008/

This should be non-blocking for M59 as we're already going beta.

We're not blocking M-59 beta but we'd like to cherry pick to M-59 for dogfooders.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f3f0f6ca2b43f458dd69e2010a2e98cb44fd7ade

commit f3f0f6ca2b43f458dd69e2010a2e98cb44fd7ade
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Wed May 10 18:58:25 2017

cryptohome: Report more detailed metrics on migration failure.

BUG= chromium:719318 
TEST=Chrome OS Builds and runs.
TSET=Manually broke ecryptfs and confirmed the expected UMA reporter is called.

Change-Id: I1ad800e0fda4c921645a8d7d6898274eafee83d3
Reviewed-on: https://chromium-review.googlesource.com/500008
Commit-Ready: Kazuhiro Inaba <kinaba@chromium.org>
Tested-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/f3f0f6ca2b43f458dd69e2010a2e98cb44fd7ade/cryptohome/dircrypto_data_migrator/migration_helper.cc
[modify] https://crrev.com/f3f0f6ca2b43f458dd69e2010a2e98cb44fd7ade/cryptohome/cryptohome_metrics.h
[modify] https://crrev.com/f3f0f6ca2b43f458dd69e2010a2e98cb44fd7ade/cryptohome/dircrypto_data_migrator/migration_helper.h

Any CLs pending to mark this as fixed?

Two more is coming.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aed44111a1f008907b532b9232b6075f44e598f2

commit aed44111a1f008907b532b9232b6075f44e598f2
Author: kinaba <kinaba@chromium.org>
Date: Thu May 11 04:42:48 2017

cryptohome: Add UMA stats for the cause of migration failures.

To analyze the trend of reported failures in more detail,
this CL adds the metrics for type of failures (error code,
on which file operation it happened, and the rough category
of file paths.)

The metrics are going to be used from Chrome OS cryptohomed.
See: https://chromium-review.googlesource.com/#/c/500238/

BUG= 719318 

Review-Url: https://codereview.chromium.org/2871733005
Cr-Commit-Position: refs/heads/master@{#470808}

[modify] https://crrev.com/aed44111a1f008907b532b9232b6075f44e598f2/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/aed44111a1f008907b532b9232b6075f44e598f2/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/14c03a31100c73e66ae7fa4cce893f16ada2d54c

commit 14c03a31100c73e66ae7fa4cce893f16ada2d54c
Author: kinaba <kinaba@chromium.org>
Date: Thu May 11 07:36:41 2017

cryptohome: Add UMA enum for a skipped file error.

BUG= 719318 

Review-Url: https://codereview.chromium.org/2876763002
Cr-Commit-Position: refs/heads/master@{#470861}

[modify] https://crrev.com/14c03a31100c73e66ae7fa4cce893f16ada2d54c/tools/metrics/histograms/enums.xml

Actually, one more is needed:
https://chromium-review.googlesource.com/c/500238/

but the ChromeOS PreCQ is now broken ... :(

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/1d1770e338354cb13550e6610718ebca9e96570d

commit 1d1770e338354cb13550e6610718ebca9e96570d
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Fri May 12 05:27:44 2017

cryptohome: Add UMA stats for migration failure analysis.

BUG= chromium:719318 
TEST=echo hoge > /home/.shadow/$hash/vault/user/Cache/$anyfile and migrate.
  the values corresponding to (SourceOpen, EIO, Cache) are recorded.
TEST=cros_workon_make cryptohome --test

Change-Id: I7b963596b133002bf44d934a9653bd665b289ad8
Reviewed-on: https://chromium-review.googlesource.com/500238
Commit-Ready: Kazuhiro Inaba <kinaba@chromium.org>
Tested-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/1d1770e338354cb13550e6610718ebca9e96570d/cryptohome/cryptohome_metrics.cc
[modify] https://crrev.com/1d1770e338354cb13550e6610718ebca9e96570d/cryptohome/mount.cc
[modify] https://crrev.com/1d1770e338354cb13550e6610718ebca9e96570d/cryptohome/dircrypto_data_migrator/migration_helper.cc
[modify] https://crrev.com/1d1770e338354cb13550e6610718ebca9e96570d/cryptohome/dircrypto_data_migrator/migration_helper.h
[modify] https://crrev.com/1d1770e338354cb13550e6610718ebca9e96570d/cryptohome/cryptohome_metrics.h
[modify] https://crrev.com/1d1770e338354cb13550e6610718ebca9e96570d/cryptohome/dircrypto_data_migrator/migration_helper_unittest.cc

All set for M60.

Let me request the merge to M59 for collecting the stats from M59 dogfooders.
All the changes are additions of UMA taking codes to the migration tool,
so it doesn't affect other normal use cases.

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce257488c0737eb20a7aa876d904c70cd5acc0b5

commit ce257488c0737eb20a7aa876d904c70cd5acc0b5
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Fri May 12 07:12:34 2017

cryptohome: Add UMA stats for the cause of migration failures.

To analyze the trend of reported failures in more detail,
this CL adds the metrics for type of failures (error code,
on which file operation it happened, and the rough category
of file paths.)

The metrics are going to be used from Chrome OS cryptohomed.
See: https://chromium-review.googlesource.com/#/c/500238/

BUG= 719318 

Review-Url: https://codereview.chromium.org/2865113004
Review-Url: https://codereview.chromium.org/2871733005
Review-Url: https://codereview.chromium.org/2876763002
Cr-Original-Commit-Position: refs/heads/master@{#470808}
Review-Url: https://codereview.chromium.org/2881453004 .
Cr-Commit-Position: refs/branch-heads/3071@{#524}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/ce257488c0737eb20a7aa876d904c70cd5acc0b5/tools/metrics/histograms/histograms.xml

Only the Chrome side merge is done. Chrome OS side change needs to be merged.
Allow me to keep the approval flag still.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Blocked by a merge conflict until  Bug 722225  is merge-approved (or rejected, in the latter case I'll try manual conflict resolution.)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/dc681ca183a1d95934fadcbb978d01a61070d110

commit dc681ca183a1d95934fadcbb978d01a61070d110
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Tue May 16 11:28:46 2017

cryptohome: Report more detailed metrics on migration failure.

BUG= chromium:719318 
TEST=Chrome OS Builds and runs.
TSET=Manually broke ecryptfs and confirmed the expected UMA reporter is called.

Change-Id: I1ad800e0fda4c921645a8d7d6898274eafee83d3
Reviewed-on: https://chromium-review.googlesource.com/500008
Commit-Ready: Kazuhiro Inaba <kinaba@chromium.org>
Tested-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
(cherry picked from commit f3f0f6ca2b43f458dd69e2010a2e98cb44fd7ade)
Reviewed-on: https://chromium-review.googlesource.com/505980
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>

[modify] https://crrev.com/dc681ca183a1d95934fadcbb978d01a61070d110/cryptohome/dircrypto_data_migrator/migration_helper.cc
[modify] https://crrev.com/dc681ca183a1d95934fadcbb978d01a61070d110/cryptohome/cryptohome_metrics.h
[modify] https://crrev.com/dc681ca183a1d95934fadcbb978d01a61070d110/cryptohome/dircrypto_data_migrator/migration_helper.h

one more merge is necessary.
it still have conflicts so I'll try manual merge tomorrow.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/b460d32d3a53ffd7ac37efb5d2bef6210939b7b5

commit b460d32d3a53ffd7ac37efb5d2bef6210939b7b5
Author: Kazuhiro Inaba <kinaba@chromium.org>
Date: Wed May 17 06:26:35 2017

cryptohome: Add UMA stats for migration failure analysis.

BUG= chromium:719318 
TEST=echo hoge > /home/.shadow/$hash/vault/user/Cache/$anyfile and migrate.
  the values corresponding to (SourceOpen, EIO, Cache) are recorded.
TEST=cros_workon_make cryptohome --test

Change-Id: I7b963596b133002bf44d934a9653bd665b289ad8
Reviewed-on: https://chromium-review.googlesource.com/500238
Commit-Ready: Kazuhiro Inaba <kinaba@chromium.org>
Tested-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Dan Spaid <dspaid@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/505839

[modify] https://crrev.com/b460d32d3a53ffd7ac37efb5d2bef6210939b7b5/cryptohome/cryptohome_metrics.cc
[modify] https://crrev.com/b460d32d3a53ffd7ac37efb5d2bef6210939b7b5/cryptohome/mount.cc
[modify] https://crrev.com/b460d32d3a53ffd7ac37efb5d2bef6210939b7b5/cryptohome/dircrypto_data_migrator/migration_helper.cc
[modify] https://crrev.com/b460d32d3a53ffd7ac37efb5d2bef6210939b7b5/cryptohome/dircrypto_data_migrator/migration_helper.h
[modify] https://crrev.com/b460d32d3a53ffd7ac37efb5d2bef6210939b7b5/cryptohome/cryptohome_metrics.h
[modify] https://crrev.com/b460d32d3a53ffd7ac37efb5d2bef6210939b7b5/cryptohome/dircrypto_data_migrator/migration_helper_unittest.cc