'unicode' object has no attribute 'original_string' when parsing test_expectations failure |
||||
Issue description
We seem to be occasionally getting the following error when running Layout Tests on Swarming on windows;
-------------------------
12:38:42.239 2644 Parsing expectations ...
AttributeError raised: 'unicode' object has no attribute 'original_string'
Traceback (most recent call last):
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 68, in main
return run(port, options, args, stderr, stdout).exit_code
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 580, in run
run_details = _run_tests(port, options, args, printer)
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\run_webkit_tests.py", line 571, in _run_tests
return manager.run(args)
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\controllers\manager.py", line 132, in run
self._expectations.remove_tests(tests_in_other_chunks)
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\models\test_expectations.py", line 1186, in remove_tests
self.remove_expectation_line(test)
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\models\test_expectations.py", line 1205, in remove_expectation_line
if not self._model.has_test(test):
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\models\test_expectations.py", line 663, in has_test
return test in self._test_to_expectation_line
File "e:\b\s\w\ir\third_party\WebKit\Tools\Scripts\webkitpy\layout_tests\models\test_expectations.py", line 253, in __eq__
return (self.original_string == other.original_string
AttributeError: 'unicode' object has no attribute 'original_string'
--------------------------
https://chromium-swarm.appspot.com/task?id=35f80c7792d51110&refresh=10&show_raw=1
,
May 8 2017
,
May 8 2017
So, somewhere there is a TestExpectationLine being compared directly with a string (unicode object), which is definitely a bug. But it only occurs in particular circumstances?
,
May 9 2017
I don't understand why it is only happening on this bot and not everywhere...
,
May 9 2017
I've uploaded https://codereview.chromium.org/2872593004 But I don't yet understand why this is happening only on this machine...
,
May 9 2017
Retried the same shard on another machine and it works -> https://chromium-swarm.appspot.com/task?id=3604b4895e67e310&refresh=10&request_detail=true&show_raw=1 Retried the same shard on the same machine and it works -> https://chromium-swarm.appspot.com/task?id=3604b3f9ce437210&refresh=10&request_detail=true&show_raw=1
,
May 9 2017
Yet it happened again here -> https://chromium-swarm.appspot.com/task?id=360469e4425df010&refresh=10&show_raw=1
,
May 9 2017
Again - this working on a different machine -> https://chromium-swarm.appspot.com/task?id=3604bbbab3782210&refresh=10&show_raw=1 Again - it worked when retried on the same machine -> https://chromium-swarm.appspot.com/task?id=3604bc1a9810e810&refresh=10&show_raw=1
,
Jun 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe9de810db44d55b7638510750707a4c908143c8 commit fe9de810db44d55b7638510750707a4c908143c8 Author: tansell <tansell@chromium.org> Date: Wed Jun 07 09:26:32 2017 webkitpy: Fix removing expectation lines. BUG= 719310 Review-Url: https://codereview.chromium.org/2872593004 Cr-Commit-Position: refs/heads/master@{#477594} [modify] https://crrev.com/fe9de810db44d55b7638510750707a4c908143c8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py [modify] https://crrev.com/fe9de810db44d55b7638510750707a4c908143c8/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py
,
Jun 7 2017
This should now be fixed :-) |
||||
►
Sign in to add a comment |
||||
Comment 1 by tansell@chromium.org
, May 8 2017