New issue
Advanced search Search tips

Issue 719308 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"org.chromium.android_webview.test.WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling with {--webview-sandboxed-renderer}" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 8 2017

Issue description

"org.chromium.android_webview.test.WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling with {--webview-sandboxed-renderer}" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNykQELEgVGbGFrZSKFAW9yZy5jaHJvbWl1bS5hbmRyb2lkX3dlYnZpZXcudGVzdC5XZWJWaWV3TW9kYWxEaWFsb2dPdmVycmlkZVRlc3QjdGVzdE92ZXJyaWRlQmVmb3JlVW5sb2FkSGFuZGxpbmcgd2l0aCB7LS13ZWJ2aWV3LXNhbmRib3hlZC1yZW5kZXJlcn0M.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by yutak@chromium.org, May 8 2017

Cc: yutak@chromium.org
Owner: a...@chromium.org
Status: Assigned (was: Untriaged)
This could be due to avi's beforeunload change?

https://chromium.googlesource.com/chromium/src/+/336125f7f83771a5fc4a44affdd66327549ab1d7

Comment 2 by olka@chromium.org, May 8 2017

cl to retry on failure: https://codereview.chromium.org/2864353002
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da115c68f2b4e3fcb46daf54a6dc8aa5df2ddcd4

commit da115c68f2b4e3fcb46daf54a6dc8aa5df2ddcd4
Author: olka <olka@chromium.org>
Date: Mon May 08 14:04:44 2017

RetryOnFailure for WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling

BUG= 719308 
TBR=yfriedman@chromium.org,boliu@chromium.org,avi@chromium.org

Review-Url: https://codereview.chromium.org/2864353002
Cr-Commit-Position: refs/heads/master@{#469975}

[modify] https://crrev.com/da115c68f2b4e3fcb46daf54a6dc8aa5df2ddcd4/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

Comment 4 by olka@chromium.org, May 8 2017

Labels: -Sheriff-Chromium
Project Member

Comment 5 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a8c3317e754288840610dd169c3a93d4d34aeb1

commit 6a8c3317e754288840610dd169c3a93d4d34aeb1
Author: avi <avi@chromium.org>
Date: Tue May 09 04:31:23 2017

Deflake WebViewModalDialogOverrideTest#testOverrideBeforeUnloadHandling.

This reverts commit da115c68f2b4e3fcb46daf54a6dc8aa5df2ddcd4 which added retries, and it makes sure the touch on the view is processed before proceeding.

BUG= 719308 

Review-Url: https://codereview.chromium.org/2869563004
Cr-Commit-Position: refs/heads/master@{#470208}

[modify] https://crrev.com/6a8c3317e754288840610dd169c3a93d4d34aeb1/android_webview/javatests/src/org/chromium/android_webview/test/WebViewModalDialogOverrideTest.java

Comment 6 by a...@chromium.org, May 9 2017

Status: Fixed (was: Assigned)

Sign in to add a comment