New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 719305 link

Starred by 1 user
Status: Verified
Owner:
yhanada@chromium.org
Closed: May 2017
Cc:
█ yoshiki@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

old height of the message center is set in MessageListView::DoUpdateIfPossible()

Project Member Reported by yhanada@chromium.org, May 8 2017 
Due to calling SetSize() before calculating new height.
Project Member

Comment 1 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa0cb2c01a36ea42448397b360dd3c39de36159

commit 4fa0cb2c01a36ea42448397b360dd3c39de36159
Author: yhanada <yhanada@chromium.org>
Date: Mon May 08 07:49:24 2017

Fix a bug that old height is set in DoUpdateIfPossible().

- Call SetSize() after calculating the new height.
- Add basic unittests for MessageListView::RemoveNotificationAt and
  MessageListView::ClearAllClosableNotifications.

TEST=message_center_unittests pass.
BUG= 719305 

Review-Url: https://codereview.chromium.org/2856833002
Cr-Commit-Position: refs/heads/master@{#469916}

[modify] https://crrev.com/4fa0cb2c01a36ea42448397b360dd3c39de36159/ui/message_center/views/message_list_view.cc
[modify] https://crrev.com/4fa0cb2c01a36ea42448397b360dd3c39de36159/ui/message_center/views/message_list_view_unittest.cc

Comment 2 by yhanada@chromium.org, May 8 2017

Status: Fixed (was: Assigned)

Comment 3 by abod...@chromium.org, May 16 2017

Status: Verified (was: Fixed)
►

Sign in to add a comment