New issue
Advanced search Search tips

Issue 719298 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 719299

Blocking:
issue 717347



Sign in to add a comment

Layout Test fast/dnd/dropEffect-for-effectAllowed.html is flaky

Project Member Reported by tansell@chromium.org, May 8 2017

Issue description

The following layout test(s) is (failing|flaky) on [platform]:

 * fast/dnd/dropEffect-for-effectAllowed.html

It fails about 10% of the time. Failures happen both on Windows 7 and Windows 10.

They only seem to fail when run on swarming with sharding. It is likely that this test is dependent on another test being run to pass and each shard only runs a subset of tests.

You can see the builder here -> https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20RandomOrder?numbuilds=200


 
Blocking: 717347
Blockedon: 719299
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f6264df1bd3a73c0f8af49adfc345126eebb1cd

commit 7f6264df1bd3a73c0f8af49adfc345126eebb1cd
Author: tansell <tansell@chromium.org>
Date: Mon May 08 04:56:11 2017

LayoutTests: Disable flaky tests on Windows.

These tests are failing a small amount of the time on the Windows Random
Order bots now they are running sharded on swarming. The tests affected
are;

 * fast/css-grid-layout/grid-self-baseline-two-dimensional.html
 * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html
 * fast/dnd/dropEffect-for-effectAllowed.html
 * external/wpt/css/css-ui-3/outline-004.html

Bugs have been filed for each of the failing tests.

The most likely cause is that they depend on another test being run and
the sharding makes this no longer happening.

BUG= 717347 , 718717 , 719298 , 719299 
NOTRY=true

Review-Url: https://codereview.chromium.org/2872463002
Cr-Commit-Position: refs/heads/master@{#469907}

[modify] https://crrev.com/7f6264df1bd3a73c0f8af49adfc345126eebb1cd/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by mek@chromium.org, May 8 2017

Cc: pwnall@chromium.org
Status: Available (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, May 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fb6d3be1ab6a20735406528fecb19ec718ae110

commit 2fb6d3be1ab6a20735406528fecb19ec718ae110
Author: qyearsley <qyearsley@chromium.org>
Date: Tue May 16 02:09:01 2017

Remove flaky expectations for tests that no longer appear flaky.

Again, done with update-test-expectations.

Flakiness dashboard:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=virtual/gpu/fast/canvas/painting-on-bad-canvas.html,fast/events/message-port-start-and-close-different-microtask.html,virtual/mojo-loading/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html,virtual/threaded/animations/display-inline-style-adjust.html,fast/selectors/007a.html,http/tests/workers/terminate-during-sync-operation-file.html,virtual/mojo-loading/http/tests/workers/terminate-during-sync-operation-file.html,virtual/threaded/inspector/tracing/decode-resize.html,external/wpt/service-workers/service-worker/fetch-canvas-tainting.https.html,external/wpt/service-workers/service-worker/fetch-cors-xhr.https.html,external/wpt/service-workers/service-worker/fetch-csp.https.html,external/wpt/service-workers/service-worker/fetch-event-async-respond-with.https.html,external/wpt/service-workers/service-worker/fetch-event-respond-with-stops-propagation.https.html,external/wpt/service-workers/service-worker/fetch-request-css-base-url.https.html,external/wpt/service-workers/service-worker/fetch-response-xhr.https.html,external/wpt/service-workers/service-worker/getregistrations.https.html,http/tests/security/link-crossorigin-preload-no-cors.html,virtual/mojo-loading/http/tests/inspector/tracing/timeline-script-parse.html,tables/mozilla/bugs/bug113424.html,fast/backgrounds/background-image-relative-url-in-iframe.html,crypto/subtle/worker-subtle-crypto-concurrent.html,fast/workers/termination-early.html,fast/dnd/dropEffect-for-effectAllowed.html

BUG= 404597 , 520174 , 520194 , 596752 , 619539 , 619539 , 638693 , 658997 ,664839, 678489 , 708934 , 713050 ,713419, 713509 , 713685 , 719298 

Review-Url: https://codereview.chromium.org/2884793002
Cr-Commit-Position: refs/heads/master@{#471981}

[modify] https://crrev.com/2fb6d3be1ab6a20735406528fecb19ec718ae110/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by pwnall@chromium.org, May 16 2017

fast/dnd/dropEffect-for-effectAllowed.html is slow. This makes sense, because it simulates a lot of drag operations. Seems like it should be added to SlowTests [1], or broken into multiple tests.

[1] https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/SlowTests
Summary: Layout Test fast/dnd/dropEffect-for-effectAllowed.html is flaky (was: Layout Test fast/dnd/dropEffect-for-effectAllowed.html is flaky on Windows (when run on swarming))
Going to try adding this to SlowTests.
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5114e9e40ecac4cfb500301ad03357b96c0966d

commit c5114e9e40ecac4cfb500301ad03357b96c0966d
Author: Peter Kasting <pkasting@chromium.org>
Date: Wed May 31 21:36:07 2017

Mark a test as slow.

BUG= 719298 
TEST=none

Change-Id: I037b7ed1012ee5da35c9d6b654bea76affd9bc79
Reviewed-on: https://chromium-review.googlesource.com/519922
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476037}
[modify] https://crrev.com/c5114e9e40ecac4cfb500301ad03357b96c0966d/third_party/WebKit/LayoutTests/SlowTests

Status: Fixed (was: Available)
Optimistically marking as Fixed.
Thank you very much!

Out of curiosity (for other slow tests), would adding <meta name=timeout content=long> have worked here, or is this only parsed for WPT tests?

Sign in to add a comment