Your initial estimate for migration time included values > 1hr so cutting off at 1 hr doesn't seem reasonable to me.

How does the bucketing work? It's not linear, since it has buckets of 2-3, 14-19ms, and also range of 94-127s



Is it safe to modify now?

we can bump minimum to 1000ms (it's not too interesting to compare migration that took 2ms vs 15ms, the hot spot is in minutes, and long tail goes 1+hr)

Device cannot expect to have a battery life of 10+ hours, so any migration that spends 10+ hours is not really interesting (I guess you can suspend/resume, what happens then ?)

I have a pending change.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2af99e66a3aaaf06320651b99df6485bd3a1ac3d

commit 2af99e66a3aaaf06320651b99df6485bd3a1ac3d
Author: Junichi Uekawa <uekawa@google.com>
Date: Thu May 11 03:58:11 2017

cryptohome: Update histogram bucket for migration.

Millisecond precision in the lower end is overkill, start from 1
second. Also expand the higher end so that we know migrations that
take 1+ hours.

BUG= chromium:719275 
TEST=cros_workon_make --test chromeos-base/cryptohome
TEST=manually
cryptohome --action=mount_ex --user=<mail> --key_label=foo --create --ecryptfs
cryptohome --action=status
dd if=/dev/zero of=/home/user/<shou>/unko bs=1M count=100
cryptohome --action=unmount --user=<mail>
logged in, migrate, and observe chrome://histogram

Change-Id: Iad1b56235ad4ae649b4cd09303635002fb4b8e5f
Reviewed-on: https://chromium-review.googlesource.com/499870
Commit-Ready: Junichi Uekawa <uekawa@chromium.org>
Tested-by: Junichi Uekawa <uekawa@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>

[modify] https://crrev.com/2af99e66a3aaaf06320651b99df6485bd3a1ac3d/cryptohome/cryptohome_metrics.cc

Request to merge to M-59 to fix histogram buckets, we should be affecting dogfooding only.

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2d96bb5c8465b4a941df9768c2296e6a0ebf38ff

commit 2d96bb5c8465b4a941df9768c2296e6a0ebf38ff
Author: Junichi Uekawa <uekawa@google.com>
Date: Fri May 12 07:09:35 2017

cryptohome: Update histogram bucket for migration.

Millisecond precision in the lower end is overkill, start from 1
second. Also expand the higher end so that we know migrations that
take 1+ hours.

BUG= chromium:719275 
TEST=cros_workon_make --test chromeos-base/cryptohome
TEST=manually
cryptohome --action=mount_ex --user=<mail> --key_label=foo --create --ecryptfs
cryptohome --action=status
dd if=/dev/zero of=/home/user/<shou>/unko bs=1M count=100
cryptohome --action=unmount --user=<mail>
logged in, migrate, and observe chrome://histogram

Change-Id: Iad1b56235ad4ae649b4cd09303635002fb4b8e5f
Reviewed-on: https://chromium-review.googlesource.com/499870
Commit-Ready: Junichi Uekawa <uekawa@chromium.org>
Tested-by: Junichi Uekawa <uekawa@chromium.org>
Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
(cherry picked from commit 2af99e66a3aaaf06320651b99df6485bd3a1ac3d)
Reviewed-on: https://chromium-review.googlesource.com/503889
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
Trybot-Ready: Junichi Uekawa <uekawa@chromium.org>

[modify] https://crrev.com/2d96bb5c8465b4a941df9768c2296e6a0ebf38ff/cryptohome/cryptohome_metrics.cc

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot