Ship SwiftShader for WebGL on macOS |
||||||||||||||||||
Issue descriptionChrome Version: M58+ OS: Mac (2009), Windows What steps will reproduce the problem? (1) Visit earth.google.com/web (2) Wait for page to load What is the expected result? Page should load and user should be able to use Google Earth What happens instead? Page errors out. Same page works in Safari See : https://www.youtube.com/watch?v=MGye3SrGNck Chrome Version 58.0.3029.81 (64-bit) on an early 2011 MacBook Pro with AMD Radeon HD 6750M Few Forum posts https://productforums.google.com/forum/#!msg/chrome/kIQqBIDosic/6iMwzl4RAwAJ https://productforums.google.com/forum/#!msg/chrome/9myFeJSE_p0/LbTp7RSmAgAJ
,
May 7 2017
This issue also impacts 360 videos on youtube for affected users. User has a MacBook Pro (15-inch, Early 2011) 2 GHz Intel Core i7 8 GB 1333 MHz DDR3 with two cards (one is famous with issues) AMD Radeon HD 649 256 MB , and Intel HD Graphics 3000 512 MB. Forum : https://productforums.google.com/forum/#!msg/chrome/8PsHfvcKVmY/k5e6vhwyAgAJ
,
May 8 2017
,
May 8 2017
Unable to reproduce the issue using chrome version 58.0.3029.96 and canary 60.0.3091.0.google earth page and Webgl sites loaded without any errors. Please find the attached screen cast for the same. Machines Tested:: Windows 7 MacBook Pro (Retina, Mid 2012) with Graphics Intel HD graphics 4000 1536 MB MacBook Pro (Retina, 15 inch Mid 2014) Graphics: Intel Iris pro 1536 MB Adding MTV label for further triage MTV@ Could any one from MTV please check the issue if any have the MAC with above mentioned specifications as we don't have MacBook Pro (15-inch, Early 2011) here. Thanks,
,
May 8 2017
The GPU acceleration is intentionally disabled (therefore no WebGL, therefore no 360 videos) because Intel HD 3000 is problematic.
,
May 8 2017
Alexis was going to look into enabling SwiftShader on Mac OS X. I thought it wouldn't have much use but this seems like it could be useful.
,
May 10 2017
Removing RBS since its expected.
,
Sep 6
SwiftShader has been working on MacOS for a while now, but are there any plans of actually shipping SwiftShader on MacOS? Delegating this issue to ccameron@ to decide if we should go ahead and ship SwiftShader on MacOS or if we choose not to fix this issue.
,
Sep 6
,
Sep 6
For best interoperability of Chrome across platforms I think we should ship it on macOS and use it as WebGL's fallback (with the performance caveat) if the GPU is disabled.
,
Sep 6
,
Sep 6
If this is going to be the tracking bug for shipping SwiftShader on macOS, let's update the title to reflect that.
,
Sep 11
We should ship SwiftShader on macOS -- there are lots of configurations that we blacklist, and they should have at least some sort of WebGL fallback.
,
Sep 12
At least P2, in my opinion, especially as we continue to need to blacklist more very-old macOS GL implementations.
,
Sep 12
,
Sep 26
@ccameron: This seems to be growing in importance. Is someone looking into this? FYI, shipping SwiftShader on MacOS should be fairly straightforward. I think you just need to modify this line: https://cs.chromium.org/chromium/src/chrome/BUILD.gn?l=991 and remove the "!(is_chrome_branded && is_official_build)" restriction.
,
Sep 28
Raising to P1 as the disparity in platform support needs to be corrected. sugoi@, if you can put together the CL that could help.
,
Oct 1
Yes, we should ship SwiftShader on macOS (especially as we're aggressively blacklisting older configurations).
,
Oct 1
Alexis, please give that shiny new iMac Pro a workout! ;-)
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae commit 55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae Author: Alexis Hetu <sugoi@google.com> Date: Thu Oct 04 18:38:34 2018 Ship SwiftShader on MacOS Bug: chromium:719257 chromium:888082 Change-Id: Ie0b06c336c46fd6b801094fab0ce5d2a0446e84e Reviewed-on: https://chromium-review.googlesource.com/c/1255305 Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#596776} [modify] https://crrev.com/55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae/chrome/BUILD.gn
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0fa9d678dc3e20dbb96144aa1bb4d0976747bd4 commit c0fa9d678dc3e20dbb96144aa1bb4d0976747bd4 Author: Kevin McNee <mcnee@chromium.org> Date: Thu Oct 04 20:18:00 2018 Revert "Ship SwiftShader on MacOS" This reverts commit 55f1e51a8e070c0e45d45f2093d1fb7ba9cba6ae. Reason for revert: Suspected cause of build failure https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Mac/37508 Original change's description: > Ship SwiftShader on MacOS > > Bug: chromium:719257 chromium:888082 > Change-Id: Ie0b06c336c46fd6b801094fab0ce5d2a0446e84e > Reviewed-on: https://chromium-review.googlesource.com/c/1255305 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Reviewed-by: ccameron <ccameron@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596776} TBR=thestig@chromium.org,ccameron@chromium.org,sugoi@chromium.org,kbr@chromium.org,markchang@chromium.org Change-Id: I5382ffee2bf0636117bcc6366614df44a78d3a72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:719257 chromium:888082 Reviewed-on: https://chromium-review.googlesource.com/c/1262660 Reviewed-by: Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#596824} [modify] https://crrev.com/c0fa9d678dc3e20dbb96144aa1bb4d0976747bd4/chrome/BUILD.gn
,
Oct 4
Sorry for the problem with the symbol-related changes in that CL Alexis. I couldn't get the chrome_dump_syms build target to complete in a reasonable period of time locally, possibly because of other GN configs in my build. I tested the chrome_dsym_archive target. Can you replicate the build environment of the official builder locally and try to debug what went wrong? Please tell me if I can help.
,
Oct 7
Hey, I looked into this Friday morning, but someone more knowledgeable on the MacOS side could probably solve this much faster than I could. Basically, kbr@'s change was mostly ok, except for the _chrome_symbols_sources section. Other entries in that array appear to be packages of some sort, while the original change was just trying to add the dlsym files to that list, which is not the right way of doing this, based on the comment above that section. CCing rsesek@, who's back in the office next week and would probably know the proper way to do this. rsesek@, could you help out with this? Thanks.
,
Oct 8
The build error is:
FAILED: libswiftshader_libEGL.dylib-71.0.3571.0.breakpad
python ../../build/redirect_stdout.py libswiftshader_libEGL.dylib-71.0.3571.0.breakpad /b/c/b/Google_Chrome_Mac/src/out/Release/dump_syms -g libswiftshader_libEGL.dSYM/Contents/Resources/DWARF/libswiftshader_libEGL libswiftshader_libEGL.dylib
Could not access object file libswiftshader_libEGL.dSYM/Contents/Resources/DWARF/libswiftshader_libEGL: No such file or directory
Traceback (most recent call last):
File "../../build/redirect_stdout.py", line 19, in <module>
sys.exit(subprocess.check_call(sys.argv[2:], stdout=fp))
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
raise CalledProcessError(retcode, cmd)
but the file name in the dSYM is: "libswiftshader_libEGL.dylib.dSYM/Contents/Resources/DWARF/libswiftshader_libEGL.dylib"
The issue is that in chrome_dump_syms, the action loop assumes that the path to the dSYM contents is a source_name_part (no extension). But for dylibs it should be a source_file_part. I wonder if we can just change that to use source_file_part?
And yes, unfortunately running dsymutil takes a *long* time. It may help to turn down symbol_level=1.
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/125c8de8707bdf7badb54ff5ac375e2074893122 commit 125c8de8707bdf7badb54ff5ac375e2074893122 Author: Alexis Hetu <sugoi@google.com> Date: Thu Oct 11 19:02:24 2018 Ship SwiftShader on MacOS Also fixed swiftshader symbol generation on MacOS Bug: chromium:719257 chromium:888082 Change-Id: I5e8754c278914c519e71c77ed792f198516a1556 Reviewed-on: https://chromium-review.googlesource.com/c/1276550 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Alexis Hétu <sugoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#598874} [modify] https://crrev.com/125c8de8707bdf7badb54ff5ac375e2074893122/chrome/BUILD.gn
,
Oct 12
Unable to reproduce the issue chrome reported version# 58.0.3029.81 using MacBook Air 10.12.6 and MacBook Pro 10.13.1 with steps mentioned below: 1) Launched chrome reported version and navigated to URL: earth.google.com/web 2) Able to see page loaded successfully. @Alexis Hetu: Please find the above mentioned information and attached screenshot for your reference and let us know if we missed anything in reproducing the issue and help us in confirming the fix. Thanks!
,
Oct 12
@viswa.karala: Unless your GPU is blacklisted, you won't see the issue. In that case, launch Chrome using --disable-gpu. The page should fail to load, but should load successfully with SwiftShader after the fix.
,
Oct 12
,
Nov 9
Issue 901680 has been merged into this issue. |
||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||
Comment 1 by jainabhi...@chromium.org
, May 7 2017