Issue metadata
Sign in to add a comment
|
DCHECK failure in VPN detailed view creation |
||||||||||||||||||||
Issue descriptionChrome Version: 60.0.3091.0 What steps will reproduce the problem? (0) Run a debug build; (1) Click on status tray to open system menu; (2) Click on VPN row to open VPN detailed view. What is the expected result? System menu should switch to VPN detailed view. What happens instead? UI hits a DCHECK and crashes. I did a bisect and it seems to be caused by r469430. Following DCHECK in GetBasicImage() function in ash/system/network/network_icon.cc fails: DCHECK_NE(shill::kTypeVPN, network_type);
,
May 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c44606774b0f1ac7cd2c071cbf6a076506c7cb06 commit c44606774b0f1ac7cd2c071cbf6a076506c7cb06 Author: lesliewatkins <lesliewatkins@chromium.org> Date: Wed May 10 23:28:34 2017 Changed default image in NetworkIconImpl to null image. The default image should remain null until it is updated based on the network state. Otherwise, the DCHECK in GetBasicImage may fail for VPNs. BUG= 719208 Review-Url: https://codereview.chromium.org/2869243002 Cr-Commit-Position: refs/heads/master@{#470744} [modify] https://crrev.com/c44606774b0f1ac7cd2c071cbf6a076506c7cb06/ash/system/network/network_icon.cc
,
May 10 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lesliewatkins@chromium.org
, May 9 2017