AddReviewers failed as no sheriffs available during weekend |
||
Issue descriptionAssertionError at AddReviewers (/base/data/home/apps/s~findit-for-me/waterfall-backend:589bb41ab.400953539577225831/infra_api_clients/codereview/rietveld.py:211) at _RevertCulprit (/base/data/home/apps/s~findit-for-me/waterfall-backend:589bb41ab.400953539577225831/waterfall/create_revert_cl_pipeline.py:172) at run (/base/data/home/apps/s~findit-for-me/waterfall-backend:589bb41ab.400953539577225831/waterfall/create_revert_cl_pipeline.py:214) https://pantheon.corp.google.com/errors/9625665121039348761?time=P30D&filter&project=findit-for-me https://codereview.chromium.org/2870473002/
,
May 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5b605c9899c25813483366b0451f8443935213a6 commit 5b605c9899c25813483366b0451f8443935213a6 Author: Chan <chanli@chromium.org> Date: Thu May 25 18:41:24 2017 Remove the assertion for existance of sheriffs when add reviewers for reverts. If the revert happens on weekends, it's possible that there are no sheriffs, we should use current reviewers and only add the message. The change is for reitveld. The change for gerrit will be in a separated CL. Bug: 719189 Change-Id: I1d7ea241e27faf90ea5589cf4a3b10468733e689 Reviewed-on: https://chromium-review.googlesource.com/514451 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/5b605c9899c25813483366b0451f8443935213a6/appengine/findit/waterfall/create_revert_cl_pipeline.py [modify] https://crrev.com/5b605c9899c25813483366b0451f8443935213a6/appengine/findit/infra_api_clients/codereview/rietveld.py [modify] https://crrev.com/5b605c9899c25813483366b0451f8443935213a6/appengine/findit/infra_api_clients/codereview/test/rietveld_test.py [modify] https://crrev.com/5b605c9899c25813483366b0451f8443935213a6/appengine/findit/common/rotations.py
,
May 25 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chanli@chromium.org
, May 22 2017