DialogOverlayImpl cleans up multiple times |
||
Issue descriptionDialogOverlayImpl.close and onConnectionError are both called sometimes on the same instance. that causes cleanup() to run twice, which notifies the provider twice. only the first one should do anything.
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2519704f857e56660e21c7309f8fdd18c86a8f99 commit 2519704f857e56660e21c7309f8fdd18c86a8f99 Author: liberato <liberato@chromium.org> Date: Mon May 08 19:45:36 2017 Make multiple calls to DialogOverlayImpl.close() do nothing. Previously, multiple calls to close() would result in multiple notifications to AndroidOverlayProviderImpl. It turns out that onConnectionError is sometimes received after close(). This CL makes multiple calls to close() do nothing. BUG= 719181 TEST=DialogOverlayImplTest.testCloseOnlyClosesOnce Review-Url: https://codereview.chromium.org/2865823003 Cr-Commit-Position: refs/heads/master@{#470079} [modify] https://crrev.com/2519704f857e56660e21c7309f8fdd18c86a8f99/content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayImpl.java [modify] https://crrev.com/2519704f857e56660e21c7309f8fdd18c86a8f99/content/public/android/javatests/src/org/chromium/content/browser/androidoverlay/DialogOverlayImplTest.java
,
May 8 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by liber...@chromium.org
, May 6 2017