Issue metadata
Sign in to add a comment
|
"CertificateReportingServiceBrowserTest.DontSendOldReports" is flaky |
||||||||||||||||||||||||
Issue description"CertificateReportingServiceBrowserTest.DontSendOldReports" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlDZXJ0aWZpY2F0ZVJlcG9ydGluZ1NlcnZpY2VCcm93c2VyVGVzdC5Eb250U2VuZE9sZFJlcG9ydHMM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 8 2017
Detected 4 new flakes for test/step "CertificateReportingServiceBrowserTest.DontSendOldReports". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRAsSBUZsYWtlIjlDZXJ0aWZpY2F0ZVJlcG9ydGluZ1NlcnZpY2VCcm93c2VyVGVzdC5Eb250U2VuZE9sZFJlcG9ydHMM. This message was posted automatically by the chromium-try-flakes app.
,
May 8 2017
This looks like an actual failure. The offender is not immediately obvious.
,
May 8 2017
CL to disable https://codereview.chromium.org/2871573002/
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47801aa98c0abbb82197b9ff5d8fb6161c249faa commit 47801aa98c0abbb82197b9ff5d8fb6161c249faa Author: olka <olka@chromium.org> Date: Mon May 08 13:12:32 2017 Disabling "CertificateReportingServiceBrowserTest.DontSendOldReports" on Mac and Win (flaky) TBR=meacer@chromium.org,mattm@chromium.org BUG= 719138 Review-Url: https://codereview.chromium.org/2871573002 Cr-Commit-Position: refs/heads/master@{#469970} [modify] https://crrev.com/47801aa98c0abbb82197b9ff5d8fb6161c249faa/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
,
May 8 2017
meacer@ PTAL at failures
,
May 8 2017
,
May 19 2017
,
May 19 2017
A fix is to send a successful report and wait for it to make sure all operations on the IO thread complete.
,
Jun 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/123a65b6261c9aedc86ac67e5f270f9a9aa917bd commit 123a65b6261c9aedc86ac67e5f270f9a9aa917bd Author: meacer <meacer@chromium.org> Date: Mon Jun 05 19:21:21 2017 Fix flaky CertificateReportingServiceBrowserTest.DontSendOldReports test BUG= 719138 Review-Url: https://codereview.chromium.org/2916383005 Cr-Commit-Position: refs/heads/master@{#477053} [modify] https://crrev.com/123a65b6261c9aedc86ac67e5f270f9a9aa917bd/chrome/browser/safe_browsing/certificate_reporting_service_browsertest.cc
,
Jun 7 2017
This is fixed both because of the commit in Comment #10 and the fact that the original CL causing the flakes was reverted. So I'm marking this as fixed, and I'm going to try relanding the original CL next. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by chromium...@appspot.gserviceaccount.com
, May 7 2017