New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719120 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-08-15
OS: Android
Pri: 3
Type: Task



Sign in to add a comment

Remove miniidump filename migration logic in M63

Project Member Reported by isherman@chromium.org, May 6 2017

Issue description

I am adding some migration logic in AwBrowserProcess.java to rename "foo.dmp" to "foo.dmp.try0".  This is only needed temporarily, and can safely be removed in M61.

 
"No patch exists with that ID" :), what's the reason for the migration logic?
Ah ok, it's I see the CL now 
Updated link: https://codereview.chromium.org/2862353003/diff/60001/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java

(Sorry, I messed up some git commands, so ended up deleting the original patch set.)
The NextAction date has arrived: 2017-06-05
NextAction: 2017-08-15
Summary: Remove miniidump filename migration logic in M63 (was: Remove miniidump filename migration logic in M61)
We decided in the code review that it might be better to wait a few milestones prior to fully removing these old code paths, as some users might skip a version or two when upgrading Chrome.  I'll also be traveling a bunch during the summer, so pushing this out 'til August.
The NextAction date has arrived: 2017-08-15
What was the case in which this could fail? (or where we might drop some files)
We could drop files if users have some pending crash reports, and never ran a version of Chrome that contained the migration logic.  However, at this point it's probably the case that any pending crash reports from such old versions are not too interesting to us, especially for users who aren't stuck on those old versions.
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/616253
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/788cbde709274b58a80d246d8274e5b4fd5a11ff

commit 788cbde709274b58a80d246d8274e5b4fd5a11ff
Author: Ilya Sherman <isherman@chromium.org>
Date: Mon Aug 21 20:22:55 2017

[Cleanup] Remove some temporary filename migration logic.

R=gsennton@chromium.org

Bug:  719120 
Change-Id: Ia79a95b278d1f1af6ba8c00a522d39a94f32b03f
Reviewed-on: https://chromium-review.googlesource.com/616253
Reviewed-by: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496044}
[modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java
[modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java
[modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java
[modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java
[modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java
[modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/TestMinidumpUploaderDelegate.java

Status: Fixed (was: Started)

Sign in to add a comment