Issue metadata
Sign in to add a comment
|
Remove miniidump filename migration logic in M63 |
||||||||||||||||||||||
Issue descriptionI am adding some migration logic in AwBrowserProcess.java to rename "foo.dmp" to "foo.dmp.try0". This is only needed temporarily, and can safely be removed in M61.
,
May 8 2017
"No patch exists with that ID" :), what's the reason for the migration logic?
,
May 8 2017
Ah ok, it's I see the CL now
,
May 8 2017
Updated link: https://codereview.chromium.org/2862353003/diff/60001/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java (Sorry, I messed up some git commands, so ended up deleting the original patch set.)
,
Jun 5 2017
The NextAction date has arrived: 2017-06-05
,
Jun 5 2017
We decided in the code review that it might be better to wait a few milestones prior to fully removing these old code paths, as some users might skip a version or two when upgrading Chrome. I'll also be traveling a bunch during the summer, so pushing this out 'til August.
,
Aug 15 2017
The NextAction date has arrived: 2017-08-15
,
Aug 15 2017
What was the case in which this could fail? (or where we might drop some files)
,
Aug 15 2017
We could drop files if users have some pending crash reports, and never ran a version of Chrome that contained the migration logic. However, at this point it's probably the case that any pending crash reports from such old versions are not too interesting to us, especially for users who aren't stuck on those old versions.
,
Aug 16 2017
,
Aug 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/788cbde709274b58a80d246d8274e5b4fd5a11ff commit 788cbde709274b58a80d246d8274e5b4fd5a11ff Author: Ilya Sherman <isherman@chromium.org> Date: Mon Aug 21 20:22:55 2017 [Cleanup] Remove some temporary filename migration logic. R=gsennton@chromium.org Bug: 719120 Change-Id: Ia79a95b278d1f1af6ba8c00a522d39a94f32b03f Reviewed-on: https://chromium-review.googlesource.com/616253 Reviewed-by: Gustav Sennton <gsennton@chromium.org> Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#496044} [modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java [modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java [modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/CrashFileManager.java [modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderDelegate.java [modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploaderImpl.java [modify] https://crrev.com/788cbde709274b58a80d246d8274e5b4fd5a11ff/components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/TestMinidumpUploaderDelegate.java
,
Aug 21 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by isherman@chromium.org
, May 6 2017