ERR kernel: [ 117.983770] cros-usb-pd-charger cros-usb-pd-charger: Port 0: default case! |
||||||||
Issue descriptionNoticed this error pop in the logs from the cros-usb-pd-charger driver. It looks like we're not handling the "OTHER" case corectly. I'll fix it. Happens on Reef and friends, fwiw.
,
May 6 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b8da571be5f6d1b3c8fb637efcc5cea39e55a09b commit b8da571be5f6d1b3c8fb637efcc5cea39e55a09b Author: Benson Leung <bleung@chromium.org> Date: Thu Jul 27 20:08:33 2017 CHROMIUM: cros_usbpd-charger - Handle Other same as Proprietary On Reef and friends, this is what Apple Brick ID type chargers are categorized as. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:719114 TEST=Plug in an Apple 2.4A charger. Check that "cros-usb-pd-charger cros-usb-pd-charger: Port 0: default case!" ERR doesn't appear in dmesg anymore. Change-Id: Id70d7c6776a20b514ce799424466c87447574066 Reviewed-on: https://chromium-review.googlesource.com/499529 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org> [modify] https://crrev.com/b8da571be5f6d1b3c8fb637efcc5cea39e55a09b/drivers/power/cros_usbpd-charger.c
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/3198d8c8a7aff694f2237ee307ac45b7370d44cc commit 3198d8c8a7aff694f2237ee307ac45b7370d44cc Author: Benson Leung <bleung@chromium.org> Date: Thu Jul 27 20:08:30 2017 CHROMIUM: cros_usbpd-charger - Handle Other same as Proprietary On Reef and friends, this is what Apple Brick ID type chargers are categorized as. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:719114 TEST=Plug in an Apple 2.4A charger. Check that "cros-usb-pd-charger cros-usb-pd-charger: Port 0: default case!" ERR doesn't appear in dmesg anymore. Change-Id: Id70d7c6776a20b514ce799424466c87447574066 Reviewed-on: https://chromium-review.googlesource.com/498187 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org> [modify] https://crrev.com/3198d8c8a7aff694f2237ee307ac45b7370d44cc/drivers/power/cros_usbpd-charger.c
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/fd52f1f4a982540ab1199b8570d9bc2194129250 commit fd52f1f4a982540ab1199b8570d9bc2194129250 Author: Benson Leung <bleung@chromium.org> Date: Thu Jul 27 22:43:59 2017 CHROMIUM: cros_usbpd-charger - Handle Other same as Proprietary On Reef and friends, this is what Apple Brick ID type chargers are categorized as. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:719114 TEST=Plug in an Apple 2.4A charger. Check that "cros-usb-pd-charger cros-usb-pd-charger: Port 0: default case!" ERR doesn't appear in dmesg anymore. Change-Id: Id70d7c6776a20b514ce799424466c87447574066 Reviewed-on: https://chromium-review.googlesource.com/499628 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org> [modify] https://crrev.com/fd52f1f4a982540ab1199b8570d9bc2194129250/drivers/power/cros_usbpd-charger.c
,
Jul 27 2017
,
Aug 4 2017
Verified in Chrome OS 9807.0.0, 62.0.3176.0.
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e32a00e1618d97113274c6396bd610a02d962848 commit e32a00e1618d97113274c6396bd610a02d962848 Author: Guenter Roeck <groeck@chromium.org> Date: Thu Sep 28 02:02:57 2017 CHROMIUM: cros_usbpd-charger - Handle Other same as Proprietary On Reef and friends, this is what Apple Brick ID type chargers are categorized as. Signed-off-by: Benson Leung <bleung@chromium.org> BUG= chromium:719114 TEST=Plug in an Apple 2.4A charger. Check that "cros-usb-pd-charger cros-usb-pd-charger: Port 0: default case!" ERR doesn't appear in dmesg anymore. Change-Id: Id70d7c6776a20b514ce799424466c87447574066 Reviewed-on: https://chromium-review.googlesource.com/498187 Commit-Ready: Benson Leung <bleung@chromium.org> Tested-by: Benson Leung <bleung@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/688106 Commit-Ready: Guenter Roeck <groeck@chromium.org> Tested-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Dmitry Torokhov <dtor@chromium.org> [modify] https://crrev.com/e32a00e1618d97113274c6396bd610a02d962848/drivers/power/supply/cros_usbpd-charger.c |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bleung@chromium.org
, May 6 2017