New issue
Advanced search Search tips

Issue 719113 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: support live coverage

Project Member Reported by caseq@chromium.org, May 6 2017

Issue description

Coverage needs to update live as more code or CSS in page are used over time.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c7e58d58127b87916dfbaf423e63bf6276d80e8

commit 4c7e58d58127b87916dfbaf423e63bf6276d80e8
Author: caseq <caseq@chromium.org>
Date: Sat May 06 18:57:52 2017

DevTools: support live coverage

- support polling in CoverageModel and CoverageView
- support incremental updates in CoverageListView
- revise the way decorators are shown, make a dummy decorator and then iterate over all lines in UISourceCode, map them to original file locations and check coverage
- remove remains of mixed coverage decorators
- assume whitespace is always unused

BUG= 719113 

Review-Url: https://codereview.chromium.org/2865573003
Cr-Commit-Position: refs/heads/master@{#469856}

[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/coverage-test.js
[delete] https://crrev.com/2eddc334c95ba670f38a4a656f25ad85a7a8f565/third_party/WebKit/LayoutTests/inspector/coverage/decorations-after-inplace-formatter-expected.txt
[delete] https://crrev.com/2eddc334c95ba670f38a4a656f25ad85a7a8f565/third_party/WebKit/LayoutTests/inspector/coverage/decorations-after-inplace-formatter.html
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/decorations-after-script-formatter-expected.txt
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/decorations-after-script-formatter.html
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/gutter-css-expected.txt
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/gutter-js-expected.txt
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge-expected.txt
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/reveal-autoformat-expected.txt
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/LayoutTests/inspector/coverage/reveal-autoformat.html
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/BUILD.gn
[add] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/coverage/CoverageView.js
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/coverage/module.json
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
[modify] https://crrev.com/4c7e58d58127b87916dfbaf423e63bf6276d80e8/third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css

Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3431436da14fb7b435d830f8552280333a7dee8c

commit 3431436da14fb7b435d830f8552280333a7dee8c
Author: caseq <caseq@chromium.org>
Date: Thu May 11 22:41:07 2017

DevTools/Coverage: fix decorations in HTML

- implement mapping for inline styles in HTML locally in CoverageDecorationsManager as a workaound for bindings deficiencies;
- apply proper offsets to inline resources when mapping UI positions to resource
    byte offsets in CoverageDecorationsManager;
- (drive-by) improve bar sizing precision in CoverageListView.

BUG= 719113 

Review-Url: https://codereview.chromium.org/2861393004
Cr-Commit-Position: refs/heads/master@{#471097}

[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/LayoutTests/inspector/coverage/decorations-after-script-formatter-expected.txt
[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/LayoutTests/inspector/coverage/gutter-css-expected.txt
[add] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/LayoutTests/inspector/coverage/gutter-html-expected.txt
[add] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/LayoutTests/inspector/coverage/gutter-html.html
[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/LayoutTests/inspector/coverage/gutter-js-expected.txt
[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/LayoutTests/inspector/coverage/multiple-instances-merge-expected.txt
[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/LayoutTests/inspector/coverage/reveal-autoformat-expected.txt
[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/Source/devtools/front_end/coverage/CoverageDecorationManager.js
[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/Source/devtools/front_end/coverage/CoverageListView.js
[modify] https://crrev.com/3431436da14fb7b435d830f8552280333a7dee8c/third_party/WebKit/Source/devtools/front_end/coverage/CoverageModel.js

Comment 3 by caseq@chromium.org, May 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment