New issue
Advanced search Search tips

Issue 719104 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression
Team-Security-UX



Sign in to add a comment

Mac: Dragged URL does not fade text (except if the first word is long)

Project Member Reported by lgar...@chromium.org, May 6 2017

Issue description

Chrome 60.0.3088.3
OSX 10.12.4

What steps will reproduce the problem?
(1) Visit https://www.washingtonpost.com/
(2) Drag the security indicator

What is the expected result?
The text of the page title in the dragged URL fades on the right. See dragged-text-original.png

What happens instead?
The text is truncated after the colon. See dragged-text-dev.png
It will also truncate in the middle of a hyphenated word; see hyphen.png for an example of no-common-name.badssl.com

(A long initial word is still faed correctly; see long.png for an example of longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com)

This appears to be an unintended consequence of crrev.com/2703863004
(Note: I actually can't observe the favicon on the right in RTL mode. It also appears to be closer to the favicon, and blurry.)

avi@, could you triage?

 
dragged-text-original.png
8.9 KB View Download
dragged-text-dev.png
7.7 KB View Download
long.png
10.3 KB View Download
hyphen.png
116 KB View Download
Summary: Mac: Dragged URL does not fade text (except if the first word is long) (was: Mac: Dragged URL does not fade text (except if the first word is long()
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/740693b4ba32b11aed1fabcdd0cc92abe36430d1

commit 740693b4ba32b11aed1fabcdd0cc92abe36430d1
Author: avi <avi@chromium.org>
Date: Mon May 08 17:37:13 2017

Fix URL text drags.

Don’t allow the system to wrap them, as that defeats the fade.

BUG= 719104 
TEST=as in bug

Review-Url: https://codereview.chromium.org/2862313004
Cr-Commit-Position: refs/heads/master@{#470037}

[modify] https://crrev.com/740693b4ba32b11aed1fabcdd0cc92abe36430d1/chrome/browser/ui/cocoa/drag_util.mm

Comment 3 by a...@chromium.org, May 8 2017

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment