New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719088 link

Starred by 3 users

Issue metadata

Status: Duplicate
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Incognito New Tab Page theme background not tiling

Project Member Reported by lgar...@chromium.org, May 5 2017

Issue description

Chrome 60.0.3088.3
OSX 10.12.4

What steps will reproduce the problem?
(1) Install https://chrome.google.com/webstore/detail/grass/mmiboiefncpfjihjdedpaoammipkilla?hl=en
(2) Open an Incognito window

What is the expected result?
The background goes across the full screen.

What happens instead?
The background appears once, in the center.

On my desktop Mac (which doesn't have this problem), the <html> element has `background-repeat: repeat-x;`. See incognito-ntp-tiling-hypatia.png

On the laptop with this problem, the <html> element has `background-repeat: no-repeat;`. See incognito-ntp-tiling-agnesi.png

msramek@, it seems you're working on related code. Could you triage?
 
incognito-ntp-tiling-hypatia.png
1.3 MB View Download
incognito-ntp-tiling-agnesi.png
915 KB View Download
ping :-)

Comment 2 by treib@chromium.org, May 16 2017

Cc: treib@chromium.org
Cc: msramek@chromium.org lgar...@chromium.org
Issue 721719 has been merged into this issue.

Comment 4 by est...@chromium.org, May 16 2017

Labels: -Type-Bug -Pri-3 Pri-1 Type-Bug-Regression
For the record, I did try this as well and the tiling works for me. This is going to be tricky to debug.

But the deduplicated bug shows that the same can happen on the regular NTP, so I don't think this is Incognito-specific, or related to my recent changes, since I intentionally wrote a new CSS rather than modifying the current one to avoid surprises.

I'd prefer for someone more familiar with this area to have a look (treib@?).
I can actually repro Issue 721719 in a non-Incognito window right now (60.0.3095.5).

In addition, our "Desktop" theme [1] is supposed to tile in both directions, but tiles neither.

[1] https://chrome.google.com/webstore/detail/desktop/pafkcccccfmnjkhhndjfffifnflhkpdo?hl=en
Screen Shot 2017-05-16 at 14.55.11.png
493 KB View Download
Description: Show this description

Comment 8 by treib@chromium.org, May 17 2017

Mergedinto: 718282
Status: Duplicate (was: Assigned)
Bug 718282 seems to be the exact same thing for the non-incognito NTP. Very interesting that it happens on both, since they're almost completely distinct. They do share some of the theming code, so likely the problem is there somewhere.

Sign in to add a comment