New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 719083 link

Starred by 1 user
Status: Fixed
Owner:
█ shrike@chromium.org
Last visit > 30 days ago
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

[MacOS] Fix for Divider dimension of the PopUp-Blocker and Tab-To-Search

Project Member Reported by meh...@chromium.org, May 5 2017 
Chrome Version: Chromium 60.0.3091.0 {#469767}
OS: MacOS 10.12.4

What steps will reproduce the problem?
(1) Compare the PopUp-Blocker divider and the Tab-To-Search Divider with the new divider dimension of the Security Indicator (from  issue 677142 ).

What is the expected result? What happens instead?
The Divider of the PopUp-Blocker and the Tab-To-Search should also be 1pt.


Thanks
Mehmet
PopUp-Blocker.png
19.7 KB View Download
Tab-To-Search.png
14.0 KB View Download
(new) Security Indicator.png
33.3 KB View Download

Comment 1 by shrike@chromium.org, May 5 2017

Cc: -shrike@chromium.org
Components: UI>Browser>Omnibox
Owner: shrike@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1ce80a582eece54780574857e8fdb8d7cef1acf

commit f1ce80a582eece54780574857e8fdb8d7cef1acf
Author: shrike <shrike@chromium.org>
Date: Mon May 08 16:23:36 2017

[Mac] Refactor decoration divider code.

Reorganizes the code that draws decoration dividers into a single
method.

R=spqchan@chromium.org,avi@chromium.org
BUG= 621614 , 719083 

Review-Url: https://codereview.chromium.org/2861283002
Cr-Commit-Position: refs/heads/master@{#470004}

[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/bubble_decoration.h
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/bubble_decoration.mm
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/content_setting_decoration.mm
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/f1ce80a582eece54780574857e8fdb8d7cef1acf/chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm

Comment 3 by shrike@chromium.org, May 8 2017

Status: Fixed (was: Started)

Comment 4 by meh...@chromium.org, May 8 2017 

Thank you, shrike@. Looks great in latest Chromium #470010. Please see the screenshots.
Tab-To-Search.png
11.3 KB View Download
PopUpBlocker.png
10.5 KB View Download
►

Sign in to add a comment