New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719080 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Implement predefined options in Browser Actions context menu.

Reported by ltian@chromium.org, May 5 2017

Issue description

Implements the predefined options in Browser Actions context menu. The predefined options includes:
1. "Open in new Chrome tab": open a tab with given url in Chrome in background.
2. "Open in incognito tab": open an incognito tab with given url in Chrome.
3. "Download link": download the webpage of given url.
4. "Copy link": copy the given url.
5. "Share" & direct share: share or direct share the given url. 




 
Project Member

Comment 1 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7efcbacb378eb77a93738a5e60479c8085a5564c

commit 7efcbacb378eb77a93738a5e60479c8085a5564c
Author: ltian <ltian@chromium.org>
Date: Fri May 19 18:45:00 2017

[Android] Implement copy and open in background of Browser Actions

This CL implements two simple predefined options in Browser Action
context menu including:
1. Copy link: Copies the given url and displays a toast message for it.
It uses Android ClipBoaard api instead Chrome custom api since native
library might not be loaded when option is selected.
2. Open in incognito tab: modifies the ChromeTabbedActivity to allow
incognito tab created with FROM_EXTERNAL_APP launch type. This allows
back button closes the tab and exits Chrome.

BUG= 719080 

Review-Url: https://codereview.chromium.org/2872353004
Cr-Commit-Position: refs/heads/master@{#473256}

[modify] https://crrev.com/7efcbacb378eb77a93738a5e60479c8085a5564c/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/7efcbacb378eb77a93738a5e60479c8085a5564c/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
[modify] https://crrev.com/7efcbacb378eb77a93738a5e60479c8085a5564c/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java
[modify] https://crrev.com/7efcbacb378eb77a93738a5e60479c8085a5564c/chrome/android/java/src/org/chromium/chrome/browser/tab/TabContextMenuItemDelegate.java
[modify] https://crrev.com/7efcbacb378eb77a93738a5e60479c8085a5564c/chrome/android/java/src/org/chromium/chrome/browser/util/IntentUtils.java

Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7

commit bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7
Author: ltian <ltian@chromium.org>
Date: Wed May 31 04:06:55 2017

[Android] Show notification for opening new tab in background of Browser Actions

This CL implements the logic of display notification when selecting
"Open in new Chrome tab" from the Browser Actions context menu. Clicking
the notification will open Chrome. If the notification is for single
link, Chrome shows the current active tab, otherwise Chrome shows the
tab switcher. Opening Chrome will dismiss the notification.

BUG= 719080 

Review-Url: https://codereview.chromium.org/2876863002
Cr-Commit-Position: refs/heads/master@{#475789}

[modify] https://crrev.com/bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
[modify] https://crrev.com/bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java
[modify] https://crrev.com/bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationConstants.java
[modify] https://crrev.com/bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationUmaTracker.java
[modify] https://crrev.com/bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/bc1417c0c8f45b206f2835a0f2bdc0fa4dcad8d7/tools/metrics/histograms/enums.xml

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d85f471065fb34745869cf4301ea8cd10aafcbe

commit 9d85f471065fb34745869cf4301ea8cd10aafcbe
Author: ltian <ltian@chromium.org>
Date: Fri Jun 23 23:47:52 2017

[Android] Implement app-wise direct share and share function in Browser Action menu.

This CL implements the app-wise direct share which different source apps
have different caches for their share options in Browser Actions. Chrome
also has its own share cache. It also implements the share and direct
share functions of Browser Actions context menu.

BUG= 719080 

Review-Url: https://codereview.chromium.org/2903563003
Cr-Commit-Position: refs/heads/master@{#482074}

[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/base/android/java/src/org/chromium/base/metrics/CachedMetrics.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuHelper.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionsContextMenuItemDelegate.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuItem.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
[add] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ShareContextMenuItem.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java/src/org/chromium/chrome/browser/share/ShareParams.java
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/java_sources.gni
[modify] https://crrev.com/9d85f471065fb34745869cf4301ea8cd10aafcbe/chrome/android/javatests/src/org/chromium/chrome/browser/ShareIntentTest.java

Project Member

Comment 4 by bugdroid1@chromium.org, Jun 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7df4d3a9181f7138fb7ea00c5a8bf51db6e8250a

commit 7df4d3a9181f7138fb7ea00c5a8bf51db6e8250a
Author: tedchoc <tedchoc@chromium.org>
Date: Wed Jun 28 06:51:02 2017

Remove special casing for context menu animation for BrowserActions.

Instead of using a different animation type, generate "fake" touch
coordinates at the center of the screen to get the same result.

BUG= 719080 

Review-Url: https://codereview.chromium.org/2963583003
Cr-Commit-Position: refs/heads/master@{#482906}

[modify] https://crrev.com/7df4d3a9181f7138fb7ea00c5a8bf51db6e8250a/chrome/android/java/src/org/chromium/chrome/browser/browseractions/BrowserActionActivity.java
[modify] https://crrev.com/7df4d3a9181f7138fb7ea00c5a8bf51db6e8250a/chrome/android/java/src/org/chromium/chrome/browser/widget/ContextMenuDialog.java

Comment 5 by ltian@chromium.org, Feb 2 2018

Status: Fixed (was: Assigned)

Sign in to add a comment