New issue
Advanced search Search tips

Issue 719070 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

nassh: connection dialog should set the title attributes of input fields

Project Member Reported by vapier@chromium.org, May 5 2017

Issue description

atm we fill out the placeholder fields of input attributes so people can see that something is a username or hostname, but we don't set the title attribute.  if we did, then we'd get tooltip text for them all the time.

we already have "label" translations for these fields, so we probably should just re-use those.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/98bb70d055b603a959382d93ae7f9750769bd2c9

commit 98bb70d055b603a959382d93ae7f9750769bd2c9
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu May 11 17:53:28 2017

libdot: add some MessageManager tests

We refactor processI18nAttributes slightly to make it easier to test
the core of the code.  Otherwise, no functional changes.

BUG= chromium:719070 

Change-Id: I353b789f0e701e3f87e06d3a564373a7537f08f1
Reviewed-on: https://chromium-review.googlesource.com/502207
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/98bb70d055b603a959382d93ae7f9750769bd2c9/libdot/html/lib_test.html
[modify] https://crrev.com/98bb70d055b603a959382d93ae7f9750769bd2c9/libdot/js/lib_message_manager.js
[add] https://crrev.com/98bb70d055b603a959382d93ae7f9750769bd2c9/libdot/js/lib_message_manager_tests.js

Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/2617525831f52b4c4024e8f3bd735bf9b3063d07

commit 2617525831f52b4c4024e8f3bd735bf9b3063d07
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu May 11 17:55:25 2017

libdot: allow i18n translations to refer to each other

Sometimes we want the same translation to be loaded into different node
attributes.  For example, the aria-label and title translations often
can re-use the same content.  This can be done today by doing:
  <input id='field-description' type='text'
         i18n='{"aria-label": "$id", "title": "FIELD_DESCRIPTION_ARIA_LABEL"}' required>

But this is unweildy when needed for more than just one field.  Instead,
let's add an "=" syntax so that one i18n attribute can refer to another.
Now the example above looks like:
  <input id='field-description' type='text'
         i18n='{"aria-label": "$id", "title": "=aria-label"}' required>

BUG= chromium:719070 

Change-Id: I6ed43e35d84eed958405c19fe57b589192e86b8f
Reviewed-on: https://chromium-review.googlesource.com/502208
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2617525831f52b4c4024e8f3bd735bf9b3063d07/libdot/js/lib_message_manager.js
[modify] https://crrev.com/2617525831f52b4c4024e8f3bd735bf9b3063d07/libdot/js/lib_message_manager_tests.js

Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/3da988c5d74979b7fbdffc0d5005f850b641e3b9

commit 3da988c5d74979b7fbdffc0d5005f850b641e3b9
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu May 11 17:55:38 2017

nassh: set the title attribute of unlabeled fields

For connection fields that lack an explicit text label, set the title
attribute so that people can mouse over the field and get a tooltip.

BUG= chromium:719070 

Change-Id: Id977d8bd7c14c797408d1bd9a8005e0bbaba87bd
Reviewed-on: https://chromium-review.googlesource.com/502209
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3da988c5d74979b7fbdffc0d5005f850b641e3b9/nassh/html/nassh_connect_dialog.html

Comment 4 by vapier@chromium.org, May 11 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)
this is part of 0.8.36.4+

Sign in to add a comment