New issue
Advanced search Search tips

Issue 719058 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: Show product information in console context selector

Project Member Reported by einbinder@chromium.org, May 5 2017

Issue description

It is hard to identify where execution contexts come from.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3d32c02c99794b0b61f38d7b66011d5595bab2a

commit d3d32c02c99794b0b61f38d7b66011d5595bab2a
Author: einbinder <einbinder@chromium.org>
Date: Fri May 12 03:35:55 2017

DevTools: Display product information in ConsoleContextSelector

BUG= 719058 

Review-Url: https://codereview.chromium.org/2842843003
Cr-Commit-Position: refs/heads/master@{#471208}

[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-on-call-frame-inside-iframe.html
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
[add] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/console/consoleContextSelector.css
[add] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/console/consoleContextSelectorButton.css
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/console/module.json
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/ui/ListControl.js
[modify] https://crrev.com/d3d32c02c99794b0b61f38d7b66011d5595bab2a/third_party/WebKit/Source/devtools/front_end/ui/toolbar.css

Project Member

Comment 2 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9eaa9ffde680190e6c32965bf66ec92be1df7ef1

commit 9eaa9ffde680190e6c32965bf66ec92be1df7ef1
Author: einbinder <einbinder@chromium.org>
Date: Thu May 18 04:38:59 2017

DevTools: Show badges instead of products in ConsoleContextSelector

BUG= 719058 

Review-Url: https://codereview.chromium.org/2889833003
Cr-Commit-Position: refs/heads/master@{#472666}

[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/LayoutTests/inspector/console/console-context-selector.html
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-links-expected.txt
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/LayoutTests/inspector/console/console-log-linkify-stack-in-errors-expected.txt
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/LayoutTests/inspector/console/console-log-object-with-getter-expected.txt
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/LayoutTests/inspector/console/console-object-preview-expected.txt
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/LayoutTests/inspector/console/console-proxy-expected.txt
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/Source/devtools/front_end/console/ConsoleContextSelector.js
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/Source/devtools/front_end/console/consoleContextSelector.css
[modify] https://crrev.com/9eaa9ffde680190e6c32965bf66ec92be1df7ef1/third_party/WebKit/Source/devtools/front_end/product_registry/BadgePool.js

Status: Verified (was: Assigned)

Sign in to add a comment