New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 719055 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 632867



Sign in to add a comment

Server Lite Pages shouldn't fall back to Client LoFi

Project Member Reported by sclit...@chromium.org, May 5 2017

Issue description

Chrome Version: 60.0.3091.0
OS: Android

What steps will reproduce the problem?
(1) Load a page that is eligible for Server Lite Pages, Server LoFi, and Client LoFi
(2) The returned page is not a Server Lite Page

What is the expected result?

The page should be shown without using Client LoFi on any of the images, since fallback from Server Lite Pages to Server LoFi is not launched yet and Client LoFi should follow the same rules.

What happens instead?

Client LoFi is used for https:// images on the page.
 

Comment 1 by bengr@chromium.org, May 8 2017

To clarify, on HTTP pages, client LoFi should be used whenever server LoFi is. If we have an experiment to fall back from Lite Pages to server LoFi, then it should also fall back from Lite Pages to client LoFi.

Comment 2 by bengr@chromium.org, May 8 2017

Labels: OS-Android
Project Member

Comment 3 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c487f12607e6cde6cbe17854013e355a18e71b5d

commit c487f12607e6cde6cbe17854013e355a18e71b5d
Author: megjablon <megjablon@chromium.org>
Date: Mon May 08 19:56:48 2017

Keep Lite Page bit set

Since Lite Page fallback will not be done via the client, client Lo-Fi
should not be shown if a Lite Page was requested. Do not clear the Lite
Page bit.

BUG= 719055 

Review-Url: https://codereview.chromium.org/2856223008
Cr-Commit-Position: refs/heads/master@{#470090}

[modify] https://crrev.com/c487f12607e6cde6cbe17854013e355a18e71b5d/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/c487f12607e6cde6cbe17854013e355a18e71b5d/tools/chrome_proxy/webdriver/lite_page.py

Comment 4 by bengr@chromium.org, May 9 2017

Status: Started (was: Assigned)
Status: Fixed (was: Started)

Sign in to add a comment