We want a compact/efficient way to represent finch group membership that gets us all the information we need while also complying with privacy/deletion requests.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c31f37835d19c5bea950cf3fe05f8ebedf11574 commit 1c31f37835d19c5bea950cf3fe05f8ebedf11574 Author: skym <skym@chromium.org> Date: Sat May 13 00:17:16 2017 Adding RegisterDependantFieldTrial interface method. BUG=719038 Review-Url: https://codereview.chromium.org/2880683002 Cr-Commit-Position: refs/heads/master@{#471505} [modify] https://crrev.com/1c31f37835d19c5bea950cf3fe05f8ebedf11574/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/1c31f37835d19c5bea950cf3fe05f8ebedf11574/components/sync/protocol/user_event_specifics.proto [modify] https://crrev.com/1c31f37835d19c5bea950cf3fe05f8ebedf11574/components/sync/user_events/user_event_service.cc [modify] https://crrev.com/1c31f37835d19c5bea950cf3fe05f8ebedf11574/components/sync/user_events/user_event_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/859454a89a9ff75119feadd780b4941bdffa31e6 commit 859454a89a9ff75119feadd780b4941bdffa31e6 Author: Sky Malice <skym@chromium.org> Date: Fri Dec 01 20:46:06 2017 [Sync] Record FieldTrial user events. FieldTrials should be recorded through sync when an event logger client registers a dependency, their dependent event is recorded, and the trial is finalized. All trials are recorded whenever the FieldTrial event is emitted, which should be on a change or period, but no more. Feature [and params] exist but may never actually change. Because FieldTrials (and other imminent types) are not tied to navigations, reworked the ShouldRecordEvent() check to be more permissive, but also enforce presence (or lack) of navigation id. Bug: 719038 Change-Id: Ib62a18949dde41d194935347768b3fef0d2623d6 Reviewed-on: https://chromium-review.googlesource.com/764408 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#521052} [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/chrome/browser/sync/test/integration/single_client_user_events_sync_test.cc [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/BUILD.gn [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/driver/sync_driver_switches.cc [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/driver/sync_driver_switches.h [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/protocol/proto_visitors.h [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/protocol/user_event_specifics.proto [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/DEPS [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/fake_user_event_service.cc [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/fake_user_event_service.h [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/no_op_user_event_service.cc [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/no_op_user_event_service.h [add] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/trial_recorder.cc [add] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/trial_recorder.h [add] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/trial_recorder_unittest.cc [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/user_event_service.h [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/user_event_service_impl.cc [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/user_event_service_impl.h [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/sync/user_events/user_event_service_impl_unittest.cc [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/variations/BUILD.gn [modify] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/variations/variations_associated_data.h [add] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/variations/variations_id_collection.cc [add] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/variations/variations_id_collection.h [add] https://crrev.com/859454a89a9ff75119feadd780b4941bdffa31e6/components/variations/variations_id_collection_unittest.cc
Client should be working correctly, but b/69678912 is still blocking this functionality.
Comment 1 by s...@chromium.org
, May 5 2017