Tracking issue for general work on view-based lock screen.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65bb182d82588d3c7e8723c4bd45c3219d121cb4 commit 65bb182d82588d3c7e8723c4bd45c3219d121cb4 Author: jdufault <jdufault@chromium.org> Date: Tue May 09 04:19:26 2017 cros: Initial structure for views-based lock. BUG= 719015 Review-Url: https://codereview.chromium.org/2859363003 Cr-Commit-Position: refs/heads/master@{#470196} [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/ash/BUILD.gn [add] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/ash/login/views/lock_contents_view.cc [add] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/ash/login/views/lock_contents_view.h [add] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/ash/login/views/lock_screen.cc [add] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/ash/login/views/lock_screen.h [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/lock/screen_locker.h [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/lock/screen_locker_tester.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/lock/webui_screen_locker.h [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/signin_screen_controller.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/ui/lock_window.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/login/ui/lock_window.h [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/power/renderer_freezer.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/65bb182d82588d3c7e8723c4bd45c3219d121cb4/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30c518245c94361d0eb5077e278782d49b9f9cd5 commit 30c518245c94361d0eb5077e278782d49b9f9cd5 Author: jdufault <jdufault@chromium.org> Date: Wed May 10 20:37:20 2017 cros: Move ash/login/views to ash/login/ui This is a follow-up commit to https://codereview.chromium.org/2859363003/. BUG= 719015 Review-Url: https://codereview.chromium.org/2873433005 Cr-Commit-Position: refs/heads/master@{#470693} [modify] https://crrev.com/30c518245c94361d0eb5077e278782d49b9f9cd5/ash/BUILD.gn [rename] https://crrev.com/30c518245c94361d0eb5077e278782d49b9f9cd5/ash/login/ui/lock_contents_view.cc [rename] https://crrev.com/30c518245c94361d0eb5077e278782d49b9f9cd5/ash/login/ui/lock_contents_view.h [rename] https://crrev.com/30c518245c94361d0eb5077e278782d49b9f9cd5/ash/login/ui/lock_screen.cc [rename] https://crrev.com/30c518245c94361d0eb5077e278782d49b9f9cd5/ash/login/ui/lock_screen.h [modify] https://crrev.com/30c518245c94361d0eb5077e278782d49b9f9cd5/chrome/browser/chromeos/login/lock/screen_locker.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b2f92e7444305d3132176edc5709b0805c9847a commit 1b2f92e7444305d3132176edc5709b0805c9847a Author: jdufault <jdufault@chromium.org> Date: Thu May 11 02:58:12 2017 cros: Move LockWindow from chrome to ash The lock screen is moving from webui to views, and we need to instantiate the LockWindow inside of ash (since that is where the views code resides). BUG= 719015 Review-Url: https://codereview.chromium.org/2867173003 Cr-Commit-Position: refs/heads/master@{#470785} [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/ash/BUILD.gn [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/ash/login/ui/lock_screen.cc [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/ash/login/ui/lock_screen.h [rename] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/ash/login/ui/lock_window.cc [rename] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/ash/login/ui/lock_window.h [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/1b2f92e7444305d3132176edc5709b0805c9847a/chrome/browser/chromeos/login/lock/webui_screen_locker.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad35cf4c798788d0d17f025e2ff5b15c61ce7985 commit ad35cf4c798788d0d17f025e2ff5b15c61ce7985 Author: jdufault <jdufault@chromium.org> Date: Wed May 24 20:51:27 2017 cros: Set owners for ash/login BUG= 719015 Review-Url: https://codereview.chromium.org/2903093002 Cr-Commit-Position: refs/heads/master@{#474413} [add] https://crrev.com/ad35cf4c798788d0d17f025e2ff5b15c61ce7985/ash/login/OWNERS
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/87469729cfc60bc4cc139dc55b2410bda8f65e5f commit 87469729cfc60bc4cc139dc55b2410bda8f65e5f Author: jdufault <jdufault@chromium.org> Date: Fri May 26 21:25:55 2017 cros: Pull TestLockScreenClient into a separate MockLockScreenClient file. - converted the class to a mock. - made it easy for tests to create an instance by defining a helper method. BUG= 719015 Review-Url: https://codereview.chromium.org/2894193002 Cr-Commit-Position: refs/heads/master@{#475135} [modify] https://crrev.com/87469729cfc60bc4cc139dc55b2410bda8f65e5f/ash/BUILD.gn [modify] https://crrev.com/87469729cfc60bc4cc139dc55b2410bda8f65e5f/ash/login/lock_screen_controller_unittest.cc [add] https://crrev.com/87469729cfc60bc4cc139dc55b2410bda8f65e5f/ash/login/mock_lock_screen_client.cc [add] https://crrev.com/87469729cfc60bc4cc139dc55b2410bda8f65e5f/ash/login/mock_lock_screen_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0933f4586224dd6de793b6118b763910e0a19d92 commit 0933f4586224dd6de793b6118b763910e0a19d92 Author: jdufault <jdufault@chromium.org> Date: Fri May 26 23:44:25 2017 cros: Pull user info from session_controller_client.mojom into separate mojom. User info needed by login/lock screen will be provided from mutliple sources, not just session_controller (ie, login uses user_manager, lock uses session_controller). BUG= 719015 Review-Url: https://codereview.chromium.org/2911493002 Cr-Commit-Position: refs/heads/master@{#475193} [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/BUILD.gn [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/session_controller.mojom [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/session_controller.typemap [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/session_controller_traits.h [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/typemaps.gni [add] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/user_info.mojom [add] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/user_info.typemap [add] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/public/interfaces/user_info_traits.h [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/session/session_controller.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/session/session_controller_unittest.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/system/supervised/tray_supervised_user.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/system/user/tray_user.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/system/user/tray_user_unittest.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/system/user/user_card_view.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/system/user/user_view.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/ash/test/test_session_controller_client.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/chrome/browser/ui/ash/session_controller_client.cc [modify] https://crrev.com/0933f4586224dd6de793b6118b763910e0a19d92/chrome/browser/ui/ash/session_controller_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e8a1b15604183c428d3515ef46556ecd49a5eea commit 7e8a1b15604183c428d3515ef46556ecd49a5eea Author: jdufault <jdufault@chromium.org> Date: Fri May 26 23:45:10 2017 cros: Fix potential null-deref when sleeping system on views-lock. BUG= 719015 Review-Url: https://codereview.chromium.org/2910733002 Cr-Commit-Position: refs/heads/master@{#475194} [modify] https://crrev.com/7e8a1b15604183c428d3515ef46556ecd49a5eea/chrome/browser/chromeos/power/renderer_freezer.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb4c9f1ea4721f5d35f19a89481bb16560330a76 commit eb4c9f1ea4721f5d35f19a89481bb16560330a76 Author: jdufault <jdufault@chromium.org> Date: Thu Jun 08 23:08:30 2017 cros: Make sure views-based lock screen is destroyed after it is dismissed. Add a CHECK to verify we only ever display one lock screen. BUG= 719015 Review-Url: https://codereview.chromium.org/2896093003 Cr-Commit-Position: refs/heads/master@{#478117} [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/lock_screen_controller.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/lock_screen_controller.h [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/lock_screen_controller_unittest.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/mock_lock_screen_client.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/mock_lock_screen_client.h [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/ui/lock_screen.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/login/ui/lock_screen.h [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/ash/public/interfaces/lock_screen.mojom [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/chrome/browser/chromeos/login/lock/screen_locker.h [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/chrome/browser/ui/ash/lock_screen_client.cc [modify] https://crrev.com/eb4c9f1ea4721f5d35f19a89481bb16560330a76/chrome/browser/ui/ash/lock_screen_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d979ce246d8afa995c88357c2a5288702e6d032f commit d979ce246d8afa995c88357c2a5288702e6d032f Author: jdufault <jdufault@chromium.org> Date: Mon Jun 12 21:00:10 2017 cros: Simple password view for lock. Adds test support. This CL primarily adds test support code; the password view is still WIP. BUG= 719015 Review-Url: https://codereview.chromium.org/2896533002 Cr-Commit-Position: refs/heads/master@{#478758} [modify] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/BUILD.gn [add] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/login/ui/login_password_view.cc [add] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/login/ui/login_password_view.h [add] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/login/ui/login_password_view_test.cc [add] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/login/ui/login_test_base.cc [add] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/login/ui/login_test_base.h [modify] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/system/tray/size_range_layout.cc [modify] https://crrev.com/d979ce246d8afa995c88357c2a5288702e6d032f/ash/system/tray/size_range_layout.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b152b7dec29161babf55e01a92305efcbb76dab commit 8b152b7dec29161babf55e01a92305efcbb76dab Author: Jacob Dufault <jdufault@google.com> Date: Fri Jun 16 21:43:51 2017 cros: Add a functional PIN keyboard view. The view is not visually up to spec, but implements all of the required functionality and integrates into the password view. Bug: 719015 Change-Id: Idecf0eb186ef5c027d04646cc2697f9cc8b16b81 Reviewed-on: https://chromium-review.googlesource.com/537673 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#480184} [modify] https://crrev.com/8b152b7dec29161babf55e01a92305efcbb76dab/ash/BUILD.gn [modify] https://crrev.com/8b152b7dec29161babf55e01a92305efcbb76dab/ash/login/ui/login_password_view.cc [modify] https://crrev.com/8b152b7dec29161babf55e01a92305efcbb76dab/ash/login/ui/login_password_view.h [add] https://crrev.com/8b152b7dec29161babf55e01a92305efcbb76dab/ash/login/ui/login_pin_view.cc [add] https://crrev.com/8b152b7dec29161babf55e01a92305efcbb76dab/ash/login/ui/login_pin_view.h [add] https://crrev.com/8b152b7dec29161babf55e01a92305efcbb76dab/ash/login/ui/login_pin_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db20a4e2b78608669a6572bdb3eedc3853f4657e commit db20a4e2b78608669a6572bdb3eedc3853f4657e Author: Jacob Dufault <jdufault@google.com> Date: Wed Jun 21 21:10:55 2017 cros: Refactor ash/login/ui/lock_screen.cc into an ash::LockScreen type. Bug: 719015 Change-Id: Icb178ad9ececef9cde13909c76457b4fd0721a0a Reviewed-on: https://chromium-review.googlesource.com/540335 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#481301} [modify] https://crrev.com/db20a4e2b78608669a6572bdb3eedc3853f4657e/ash/login/lock_screen_controller.cc [modify] https://crrev.com/db20a4e2b78608669a6572bdb3eedc3853f4657e/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/db20a4e2b78608669a6572bdb3eedc3853f4657e/ash/login/ui/lock_screen.cc [modify] https://crrev.com/db20a4e2b78608669a6572bdb3eedc3853f4657e/ash/login/ui/lock_screen.h [modify] https://crrev.com/db20a4e2b78608669a6572bdb3eedc3853f4657e/chrome/browser/chromeos/login/lock/screen_locker.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c906a86ff02d547c59e9b65c71e348973641fc3 commit 0c906a86ff02d547c59e9b65c71e348973641fc3 Author: Jacob Dufault <jdufault@google.com> Date: Thu Jun 22 00:19:05 2017 cros: Show a more complete lock screen UI integrating existing views. This also introduces LoginDataSource, which abstracts how the UI receives state. It enables a debug overlay which intercepts and resends events with different data (ie, number of users). Bug: 719015 Change-Id: If267216bfb814339c6398bef6124945f065cb10f Reviewed-on: https://chromium-review.googlesource.com/540159 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#481371} [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/BUILD.gn [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/lock_contents_view.h [add] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/lock_contents_view_unittest.cc [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/lock_screen.cc [add] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/lock_window.cc [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/lock_window.h [add] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/login_data_dispatcher.cc [add] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/login_data_dispatcher.h [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/login_test_base.cc [modify] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/login_test_base.h [add] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/login_test_utils.cc [add] https://crrev.com/0c906a86ff02d547c59e9b65c71e348973641fc3/ash/login/ui/login_test_utils.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce73e780941d7859c4e9db0a41ddeabdb867f723 commit ce73e780941d7859c4e9db0a41ddeabdb867f723 Author: Jacob Dufault <jdufault@google.com> Date: Tue Jun 27 19:29:52 2017 cros: Add debug overlay for views-lock screen. Bug: 719015 Change-Id: I9d5ef312a85ded1af29d6fabb078bdfedbdc04da Reviewed-on: https://chromium-review.googlesource.com/540078 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#482712} [modify] https://crrev.com/ce73e780941d7859c4e9db0a41ddeabdb867f723/ash/BUILD.gn [add] https://crrev.com/ce73e780941d7859c4e9db0a41ddeabdb867f723/ash/login/ui/lock_debug_view.cc [add] https://crrev.com/ce73e780941d7859c4e9db0a41ddeabdb867f723/ash/login/ui/lock_debug_view.h [modify] https://crrev.com/ce73e780941d7859c4e9db0a41ddeabdb867f723/ash/login/ui/lock_screen.cc [modify] https://crrev.com/ce73e780941d7859c4e9db0a41ddeabdb867f723/chromeos/chromeos_switches.cc [modify] https://crrev.com/ce73e780941d7859c4e9db0a41ddeabdb867f723/chromeos/chromeos_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97eb601663717c36b21327eccc9d14bee1bce9d7 commit 97eb601663717c36b21327eccc9d14bee1bce9d7 Author: Jacob Dufault <jdufault@google.com> Date: Tue Jun 27 20:17:39 2017 cros: Animate PIN keyboard entry/exit on views lock screen. Bug: 719015 Change-Id: I4d402e416d4a1721f4fd1125858cbc0a482f0bdd Reviewed-on: https://chromium-review.googlesource.com/549071 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#482726} [modify] https://crrev.com/97eb601663717c36b21327eccc9d14bee1bce9d7/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/97eb601663717c36b21327eccc9d14bee1bce9d7/ash/login/ui/lock_contents_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e88c30479190a74ad7599511e3b7dcffa74359c commit 8e88c30479190a74ad7599511e3b7dcffa74359c Author: Jacob Dufault <jdufault@google.com> Date: Thu Jun 29 23:09:16 2017 cros: Add toggle blur to views-lock debug menu. It is useful for measuring the impact wallpaper blur has on performance. Bug: 719015 Change-Id: I58f6fe66f6d8e1861d4ad8679ea08521f5871a40 Reviewed-on: https://chromium-review.googlesource.com/556880 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#483533} [modify] https://crrev.com/8e88c30479190a74ad7599511e3b7dcffa74359c/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/8e88c30479190a74ad7599511e3b7dcffa74359c/ash/login/ui/lock_debug_view.h [modify] https://crrev.com/8e88c30479190a74ad7599511e3b7dcffa74359c/ash/login/ui/lock_screen.cc [modify] https://crrev.com/8e88c30479190a74ad7599511e3b7dcffa74359c/ash/login/ui/lock_screen.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d86871c7511c6a2f76468afb953c6219c7083097 commit d86871c7511c6a2f76468afb953c6219c7083097 Author: xiaoyinh <xiaoyinh@chromium.org> Date: Fri Jun 30 00:53:30 2017 Populate password into mojo api. BUG= 719015 Review-Url: https://codereview.chromium.org/2963233002 Cr-Commit-Position: refs/heads/master@{#483564} [modify] https://crrev.com/d86871c7511c6a2f76468afb953c6219c7083097/ash/login/ui/login_auth_user_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/95b28c48a98d0cdcbdfd47d94e29e1b88636461e commit 95b28c48a98d0cdcbdfd47d94e29e1b88636461e Author: Jacob Dufault <jdufault@google.com> Date: Fri Jul 14 01:11:46 2017 cros: Give fake users a unique account id and name. Bug: 719015 Change-Id: I4873c3702c3aeff4fad161b77abed959313e2033 Reviewed-on: https://chromium-review.googlesource.com/570819 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#486583} [modify] https://crrev.com/95b28c48a98d0cdcbdfd47d94e29e1b88636461e/ash/login/ui/lock_debug_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f5f9ae095013f7e524d5391340a5f393e464dda commit 6f5f9ae095013f7e524d5391340a5f393e464dda Author: Jacob Dufault <jdufault@google.com> Date: Fri Jul 14 23:12:11 2017 cros: Rename some constants in lock_contents_view.cc Bug: 719015 Change-Id: I464db646324b3ff9da3ecb203b36f82b8edc81ae Reviewed-on: https://chromium-review.googlesource.com/563977 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#486920} [modify] https://crrev.com/6f5f9ae095013f7e524d5391340a5f393e464dda/ash/login/ui/lock_contents_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/745c82afc6ac9c761b522118663787af78860db9 commit 745c82afc6ac9c761b522118663787af78860db9 Author: Sarah Hu <xiaoyinh@chromium.org> Date: Fri Jul 14 23:21:58 2017 Update pin keyboard UI in the views based lockscreen. Refine the pin keyboard UI in the lockscreen which includes 1. Update the style/icon of the pin button 2. Tweak the spacing between user view, password view and pin keyboard. 3. Add ripple to pin button. Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw Bug: 719015 Change-Id: I83a2ea93848498f9bb4023cfb677aa176b3b4174 Reviewed-on: https://chromium-review.googlesource.com/562239 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Terry Anderson <tdanderson@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#486932} [modify] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/login/ui/login_password_view.cc [modify] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/login/ui/login_pin_view.cc [modify] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/login/ui/login_pin_view.h [modify] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/login/ui/login_user_view.cc [modify] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/resources/vector_icons/lock_screen_arrow.1x.icon [add] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/resources/vector_icons/lock_screen_arrow.icon [add] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/resources/vector_icons/lock_screen_backspace.1x.icon [add] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/resources/vector_icons/lock_screen_backspace.icon [add] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/resources/vector_icons/lock_screen_dropdown.1x.icon [add] https://crrev.com/745c82afc6ac9c761b522118663787af78860db9/ash/resources/vector_icons/lock_screen_dropdown.icon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc114d1834eaabf8a540a69bcea74934df33b7c4 commit cc114d1834eaabf8a540a69bcea74934df33b7c4 Author: Jacob Dufault <jdufault@google.com> Date: Mon Jul 24 21:12:48 2017 cros: Layout views-based lock according to spec in portrait mode. Views-based lock will automatically use the correct portrait or landscape layout. If the screen rotates the view hierarchy will relayout and adjust sizing as needed. Bug: 719015 Change-Id: Id6fa60d7aeaad93eb6d47c8028ae8ea5dffae955 Reviewed-on: https://chromium-review.googlesource.com/564017 Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#489076} [modify] https://crrev.com/cc114d1834eaabf8a540a69bcea74934df33b7c4/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/cc114d1834eaabf8a540a69bcea74934df33b7c4/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/cc114d1834eaabf8a540a69bcea74934df33b7c4/ash/login/ui/lock_contents_view_unittest.cc [modify] https://crrev.com/cc114d1834eaabf8a540a69bcea74934df33b7c4/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/cc114d1834eaabf8a540a69bcea74934df33b7c4/ash/login/ui/lock_debug_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5836e5362717711d16e176089d06675e6de97c6c commit 5836e5362717711d16e176089d06675e6de97c6c Author: Jacob Dufault <jdufault@google.com> Date: Wed Aug 16 20:00:25 2017 cros: Animate views-based login. This CL does a couple of closely related activities: - enables (animated) user switching - updates PIN keyboard animation and restructures existing PIN keyboard animation to handle user switching Animation: https://goto.google.com/nrzno Bug: 719015 Change-Id: Ie769f6bfc47aa6b6959b66bfc69768351834c47c Reviewed-on: https://chromium-review.googlesource.com/572237 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#494910} [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/BUILD.gn [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/lock_contents_view_unittest.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_auth_user_view_unittest.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_constants.h [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_password_view.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_password_view.h [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_pin_view.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_pin_view.h [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_test_base.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_test_utils.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_test_utils.h [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_user_view.cc [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_user_view.h [modify] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/login_user_view_unittest.cc [add] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/pin_keyboard_animation.cc [add] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/pin_keyboard_animation.h [add] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/user_switch_flip_animation.cc [add] https://crrev.com/5836e5362717711d16e176089d06675e6de97c6c/ash/login/ui/user_switch_flip_animation.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8674c19bcc3997d76afba03341f882f3fd384107 commit 8674c19bcc3997d76afba03341f882f3fd384107 Author: Jacob Dufault <jdufault@google.com> Date: Wed Aug 16 22:33:42 2017 cros: Remove old wallpaper rendering. This has been replaced with the real implementation. When that landed it did not remove the existing implementation for views. Bug: 719015 Change-Id: I01f92de0f796047150f3c1bebfccf142e1c40a32 Reviewed-on: https://chromium-review.googlesource.com/615782 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#494981} [modify] https://crrev.com/8674c19bcc3997d76afba03341f882f3fd384107/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/8674c19bcc3997d76afba03341f882f3fd384107/ash/login/ui/lock_contents_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/261b363fdaa1b60321cf32c740d038c86e677b03 commit 261b363fdaa1b60321cf32c740d038c86e677b03 Author: Jacob Dufault <jdufault@google.com> Date: Thu Aug 17 19:16:02 2017 cros: Make PIN backspace button repeat. The backspace will auto-submit if long-pressed and will then start repeating if held down. This lets the user hold backspace to delete the entire PIN. Bug: 719015 Change-Id: I76764e72deb35aca02aa4c79182a2e4dec34fbf3 Reviewed-on: https://chromium-review.googlesource.com/585689 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#495270} [modify] https://crrev.com/261b363fdaa1b60321cf32c740d038c86e677b03/ash/login/ui/login_pin_view.cc [modify] https://crrev.com/261b363fdaa1b60321cf32c740d038c86e677b03/ash/login/ui/login_pin_view.h [modify] https://crrev.com/261b363fdaa1b60321cf32c740d038c86e677b03/ash/login/ui/login_pin_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551 commit 81565fa69c0d5cdd4275fcf9d858f92b5e8aa551 Author: Jacob Dufault <jdufault@google.com> Date: Thu Aug 17 21:45:54 2017 cros: Make non-focused/active UserViews transparent. The view becomes opaque when it is focused or if the mouse is hovering over it. Bug: 719015 Change-Id: If0a1289c1aded6cc58aff4539a9d1e00bdc31d8c Reviewed-on: https://chromium-review.googlesource.com/617474 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#495330} [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_auth_user_view_unittest.cc [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_password_view.cc [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_password_view.h [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_user_view.cc [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_user_view.h [modify] https://crrev.com/81565fa69c0d5cdd4275fcf9d858f92b5e8aa551/ash/login/ui/login_user_view_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7795a865555ab8d92a7389015798306340fc8f9 commit b7795a865555ab8d92a7389015798306340fc8f9 Author: Jacob Dufault <jdufault@google.com> Date: Fri Sep 08 20:42:36 2017 cros: Allow tab/shift+tab to navigate to status area. Bug: 719015 Change-Id: Ibbe5b0aac317c5daa161329c3cd85c54bda1c4dd Reviewed-on: https://chromium-review.googlesource.com/617594 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#500650} [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/login_password_view.cc [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/login_password_view.h [modify] https://crrev.com/b7795a865555ab8d92a7389015798306340fc8f9/ash/login/ui/login_test_base.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e68efda1206af2a36f88304efffb18cccf1c9b6 commit 5e68efda1206af2a36f88304efffb18cccf1c9b6 Author: Sarah Hu <xiaoyinh@chromium.org> Date: Fri Sep 08 23:10:38 2017 Cros: Add bubbles in the views-based lockscreen This CL does the following: 1. Create bubble view for error bubble and user drop down menu bubble 2. Add pre-target handler for key events, mouse events and touch events to dismiss the bubble when necessary. Bug: 719015 Change-Id: I45a0339fd1dcffb7ce143a72a72acdf4f378bcee Reviewed-on: https://chromium-review.googlesource.com/647877 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#500727} [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/BUILD.gn [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/ash_strings.grd [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_auth_user_view.h [add] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_base_bubble_view.cc [add] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_base_bubble_view.h [add] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_bubble.cc [add] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_bubble.h [add] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_bubble_unittest.cc [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_user_view.cc [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/login/ui/login_user_view.h [modify] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/resources/vector_icons/lock_screen_alert.1x.icon [add] https://crrev.com/5e68efda1206af2a36f88304efffb18cccf1c9b6/ash/resources/vector_icons/lock_screen_alert.icon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93eeb6747d1aa925d05b63ccaef2d58b1f12318c commit 93eeb6747d1aa925d05b63ccaef2d58b1f12318c Author: Jacob Dufault <jdufault@google.com> Date: Tue Sep 12 19:17:56 2017 cros: Remove extraneous ash:: from ash/login. Also remove a LOG(ERROR) that was accidentally committed. Bug: 719015 Change-Id: Ib4564903b358cdba5c1189a5b9fac484e7c8ad16 Reviewed-on: https://chromium-review.googlesource.com/663667 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501355} [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/mock_lock_screen_client.h [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/lock_contents_view_unittest.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/lock_window.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/lock_window.h [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/login_data_dispatcher.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/login_data_dispatcher.h [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/login_password_view.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/login_pin_view.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/login_test_base.cc [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/login_test_base.h [modify] https://crrev.com/93eeb6747d1aa925d05b63ccaef2d58b1f12318c/ash/login/ui/login_user_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/916b6e43febdfbc42ea3deaf0efc69f335d8b011 commit 916b6e43febdfbc42ea3deaf0efc69f335d8b011 Author: Jacob Dufault <jdufault@google.com> Date: Fri Sep 15 00:15:55 2017 cros: Improve views-based lock accessibility. Bug: 719015 Change-Id: Iaba14afeae97d0f290b0de5e6524247405fa7213 Reviewed-on: https://chromium-review.googlesource.com/663605 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#502106} [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/BUILD.gn [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/ash_strings.grd [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/login_password_view.cc [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/login_password_view.h [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/login_pin_view.cc [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/login_pin_view.h [modify] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/login_user_view.cc [add] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/non_accessible_view.cc [add] https://crrev.com/916b6e43febdfbc42ea3deaf0efc69f335d8b011/ash/login/ui/non_accessible_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40623d5565c804b39b42adc871594fbb4566575a commit 40623d5565c804b39b42adc871594fbb4566575a Author: Jacob Dufault <jdufault@google.com> Date: Fri Sep 15 17:22:53 2017 cros: Load users via LockScreenController::LoadUsers. This unifies the code path with the WebUI implementation and gives access to additional information. Bug: 731191 , 719015 Change-Id: I69a47c30e528b489682aebd5ce4d4b17517bcd88 Reviewed-on: https://chromium-review.googlesource.com/668068 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#502293} [modify] https://crrev.com/40623d5565c804b39b42adc871594fbb4566575a/ash/login/lock_screen_controller.cc [modify] https://crrev.com/40623d5565c804b39b42adc871594fbb4566575a/ash/login/lock_screen_controller.h [modify] https://crrev.com/40623d5565c804b39b42adc871594fbb4566575a/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/40623d5565c804b39b42adc871594fbb4566575a/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/40623d5565c804b39b42adc871594fbb4566575a/ash/login/ui/lock_screen.cc [modify] https://crrev.com/40623d5565c804b39b42adc871594fbb4566575a/ash/login/ui/lock_screen.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7976c1c0a91292d675ca04a6c013cbd7dc0f75f9 commit 7976c1c0a91292d675ca04a6c013cbd7dc0f75f9 Author: Wenzhao Zang <wzang@chromium.org> Date: Thu Sep 28 23:46:32 2017 Add interface to set custom password replacement char in RenderText Currently the placeholder for obscured text is defaulted to be '*' except for Mac. However for Chrome OS lock screen we must use bullet as placeholder. Added a setter to customize the password replacement char. Bug: 719015 Change-Id: Ic874a29f68d530aa479cf9852265fe8c07d64003 Reviewed-on: https://chromium-review.googlesource.com/683598 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#505214} [modify] https://crrev.com/7976c1c0a91292d675ca04a6c013cbd7dc0f75f9/ash/login/ui/login_password_view.cc [modify] https://crrev.com/7976c1c0a91292d675ca04a6c013cbd7dc0f75f9/ui/gfx/render_text.cc [modify] https://crrev.com/7976c1c0a91292d675ca04a6c013cbd7dc0f75f9/ui/gfx/render_text.h [modify] https://crrev.com/7976c1c0a91292d675ca04a6c013cbd7dc0f75f9/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/7976c1c0a91292d675ca04a6c013cbd7dc0f75f9/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/7976c1c0a91292d675ca04a6c013cbd7dc0f75f9/ui/views/controls/textfield/textfield.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c9d690047d9c9ba352337a62133a45a02c6cadb commit 8c9d690047d9c9ba352337a62133a45a02c6cadb Author: Wenzhao Zang <wzang@chromium.org> Date: Sun Oct 01 07:48:43 2017 Update lock screen password view to match spec Make the views-based lock password view match the spec [1], except the letter spacing between password characters. We may need to subclass TextField to implement that. [1] https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZdwfnbqy2eSi/files/MCHm5Lyh8lQ6SZ3vjzwd3Uo8wMSJbxAVNpw Bug: 719015 Change-Id: I0602ab1de53f74ef1dd176ca95a4d5e8469b46ad Reviewed-on: https://chromium-review.googlesource.com/679745 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#505514} [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/ash_strings.grd [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/login/ui/login_constants.h [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/login/ui/login_password_view.cc [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/login/ui/login_password_view.h [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/login/ui/login_password_view_test.cc [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/login/ui/login_pin_view.cc [modify] https://crrev.com/8c9d690047d9c9ba352337a62133a45a02c6cadb/ash/login/ui/login_pin_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d532b5e3e3631597449c9cbd78d34f9a2750832e commit d532b5e3e3631597449c9cbd78d34f9a2750832e Author: Sarah Hu <xiaoyinh@chromium.org> Date: Thu Oct 05 00:44:58 2017 Fix focus highlight for the pin button. Bug: 719015 Change-Id: I6f7cb61a81efdad03d2128484dfb831787fb350a Reviewed-on: https://chromium-review.googlesource.com/701404 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#506591} [modify] https://crrev.com/d532b5e3e3631597449c9cbd78d34f9a2750832e/ash/login/ui/login_pin_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7dbdfb955a455cc94061b51c78cb31f9750c6325 commit 7dbdfb955a455cc94061b51c78cb31f9750c6325 Author: Jacob Dufault <jdufault@google.com> Date: Thu Oct 05 16:53:13 2017 cros: Show animated avatars in views-based lock. This adds support for parsing APNG images by hooking into the data_decoder service. webkit::WebImage API is extended to support fetching the relevant animation data from blink's PNG decoder. Bug: 750064, 719015 Change-Id: I7fb38643dce5d6e16eaaee2b6f74253ba70af20a Reviewed-on: https://chromium-review.googlesource.com/679459 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506768} [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/BUILD.gn [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/login/DEPS [add] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/login/ui/animated_rounded_image_view.cc [add] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/login/ui/animated_rounded_image_view.h [add] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/login/ui/animation_frame.h [add] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/login/ui/image_parser.cc [add] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/login/ui/image_parser.h [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/login/ui/login_user_view.cc [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/ash/public/interfaces/user_info.mojom [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/services/data_decoder/image_decoder_impl.cc [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/services/data_decoder/image_decoder_impl.h [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/services/data_decoder/public/cpp/decode_image.cc [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/services/data_decoder/public/cpp/decode_image.h [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/services/data_decoder/public/interfaces/BUILD.gn [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/services/data_decoder/public/interfaces/image_decoder.mojom [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/third_party/WebKit/Source/platform/exported/WebImage.cpp [modify] https://crrev.com/7dbdfb955a455cc94061b51c78cb31f9750c6325/third_party/WebKit/public/platform/WebImage.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/88f10e27778587150cc1ed004b9ea286145a4b1e commit 88f10e27778587150cc1ed004b9ea286145a4b1e Author: Jacob Dufault <jdufault@google.com> Date: Tue Oct 10 20:55:02 2017 cros: Destroy lock screen after session state change Bug: 719015 Change-Id: Iaa8573aa524cdb338eb351ca42259b0b862eac5c Reviewed-on: https://chromium-review.googlesource.com/709935 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#507764} [modify] https://crrev.com/88f10e27778587150cc1ed004b9ea286145a4b1e/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/88f10e27778587150cc1ed004b9ea286145a4b1e/ash/login/ui/lock_screen.cc [modify] https://crrev.com/88f10e27778587150cc1ed004b9ea286145a4b1e/ash/login/ui/lock_screen.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eafc6fe6230210c36a606ddafa1ecd42862ae5a2 commit eafc6fe6230210c36a606ddafa1ecd42862ae5a2 Author: Jacob Dufault <jdufault@google.com> Date: Wed Oct 11 21:16:52 2017 cros: Add debug option to force-fail auth on views-based lock. Force-fail auth is useful when testing auth on the desktop, as the fake cryptohome will accept any password. Bug: 719015 Change-Id: I648493f1d65aa2b4f9aeb0626566ae1c1412e210 Reviewed-on: https://chromium-review.googlesource.com/702594 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#508116} [modify] https://crrev.com/eafc6fe6230210c36a606ddafa1ecd42862ae5a2/ash/login/lock_screen_controller.cc [modify] https://crrev.com/eafc6fe6230210c36a606ddafa1ecd42862ae5a2/ash/login/lock_screen_controller.h [modify] https://crrev.com/eafc6fe6230210c36a606ddafa1ecd42862ae5a2/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/eafc6fe6230210c36a606ddafa1ecd42862ae5a2/ash/login/ui/lock_debug_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14 commit 0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Oct 13 04:48:20 2017 cros: Add caps lock icon in lock screen password view Caps lock icon is not accessible via tabbing or ChromeVox. Bug: 719015 Change-Id: I77a18eeb2d4a5204fc55b63bf776d294a561eed2 Reviewed-on: https://chromium-review.googlesource.com/710658 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#508593} [modify] https://crrev.com/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14/ash/login/ui/lock_debug_view.h [modify] https://crrev.com/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14/ash/login/ui/login_password_view.cc [modify] https://crrev.com/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14/ash/login/ui/login_password_view.h [modify] https://crrev.com/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14/ash/resources/vector_icons/BUILD.gn [add] https://crrev.com/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14/ash/resources/vector_icons/lock_screen_caps_lock.1x.icon [add] https://crrev.com/0b3fce27f3f80a25858cc2b13170fdbc9ebc4b14/ash/resources/vector_icons/lock_screen_caps_lock.icon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6b03b773923a7e84398dc8ebf5ff7615bbda122 commit c6b03b773923a7e84398dc8ebf5ff7615bbda122 Author: Jacob Dufault <jdufault@google.com> Date: Fri Oct 13 20:31:14 2017 cros: Move AnimatedRoundedImageView preferred size to ctor. No consumer needs to dynamically change the size so just make it a ctor param. Bug: 719015 Change-Id: I93617608efc409fa825dc77b3ceb6c0e4d9c4c42 Reviewed-on: https://chromium-review.googlesource.com/709741 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#508802} [modify] https://crrev.com/c6b03b773923a7e84398dc8ebf5ff7615bbda122/ash/login/ui/animated_rounded_image_view.cc [modify] https://crrev.com/c6b03b773923a7e84398dc8ebf5ff7615bbda122/ash/login/ui/animated_rounded_image_view.h [modify] https://crrev.com/c6b03b773923a7e84398dc8ebf5ff7615bbda122/ash/login/ui/login_user_view.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5738ca191803ea95e5e01b8310f2f66e43b24d9 commit c5738ca191803ea95e5e01b8310f2f66e43b24d9 Author: Jacob Dufault <jdufault@google.com> Date: Mon Oct 16 23:18:16 2017 cros: Use enum instead of string to identify easy unlock icons. Also document easy unlock API in the mojom file. Bug: 719015 Change-Id: I7ed1d2e0743af533713276f9650faa4ac32a38a7 Reviewed-on: https://chromium-review.googlesource.com/717542 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#509192} [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/ash/login/lock_screen_controller.cc [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/ash/login/lock_screen_controller.h [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/ash/public/interfaces/lock_screen.mojom [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/ash/public/interfaces/login_user_info.mojom [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/chrome/browser/chromeos/login/user_selection_screen_proxy.cc [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/chrome/browser/ui/ash/lock_screen_client.cc [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/chrome/browser/ui/ash/lock_screen_client.h [modify] https://crrev.com/c5738ca191803ea95e5e01b8310f2f66e43b24d9/components/proximity_auth/screenlock_bridge.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a022559b3f140d5d68fa80f80e1c17f8bcdd3245 commit a022559b3f140d5d68fa80f80e1c17f8bcdd3245 Author: Jacob Dufault <jdufault@google.com> Date: Tue Oct 17 21:53:38 2017 cros: Views-lock UI for easy unlock. Bug: 719015 Change-Id: Ifd689698b09d51596330b2d7d07681e9e28eb68a Reviewed-on: https://chromium-review.googlesource.com/717543 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#509557} [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/BUILD.gn [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/ash_strings.grd [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/lock_screen_controller.cc [add] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/hover_notifier.cc [add] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/hover_notifier.h [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/lock_contents_view_unittest.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/lock_debug_view.h [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_auth_user_view_unittest.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_bubble.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_bubble.h [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_data_dispatcher.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_data_dispatcher.h [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_password_view.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_password_view.h [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_password_view_test.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_user_view.cc [modify] https://crrev.com/a022559b3f140d5d68fa80f80e1c17f8bcdd3245/ash/login/ui/login_user_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f50e00e673ec8e6958a8615c9e2cda6433cb04e commit 4f50e00e673ec8e6958a8615c9e2cda6433cb04e Author: Sarah Hu <xiaoyinh@chromium.org> Date: Mon Oct 23 18:58:02 2017 cros: small UI adjustment to the lockscreen error bubble 1. Bolding some text in the error message. 2. Adjust bubble width. Bug: 719015 Change-Id: Ica1dc536e127ff04f212af81a48a59f2dea5118d Reviewed-on: https://chromium-review.googlesource.com/723843 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#510864} [modify] https://crrev.com/4f50e00e673ec8e6958a8615c9e2cda6433cb04e/ash/ash_strings.grd [modify] https://crrev.com/4f50e00e673ec8e6958a8615c9e2cda6433cb04e/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/4f50e00e673ec8e6958a8615c9e2cda6433cb04e/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/4f50e00e673ec8e6958a8615c9e2cda6433cb04e/ash/login/ui/login_base_bubble_view.cc [modify] https://crrev.com/4f50e00e673ec8e6958a8615c9e2cda6433cb04e/ash/login/ui/login_bubble.cc [modify] https://crrev.com/4f50e00e673ec8e6958a8615c9e2cda6433cb04e/ash/login/ui/login_bubble.h [modify] https://crrev.com/4f50e00e673ec8e6958a8615c9e2cda6433cb04e/ash/login/ui/login_bubble_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0e01a5322dbbd37395a85e4922231cd88067f03 commit e0e01a5322dbbd37395a85e4922231cd88067f03 Author: Sarah Hu <xiaoyinh@chromium.org> Date: Wed Oct 25 20:29:30 2017 Add UMA for ChromeOS views-based lockscreen. This CL add the following UMA: 1. Times a password was incorrectly entered (unlock, eventual success) 2. Times a password was incorrectly entered (unlock, eventual abandon) 3. Usage of PIN / Password / Smartlock (unlock) 4. Times user clicks other part of the lockscreen. 5. Unlock methods used sliced by mode (tablet / clamshell) Details can be found here: go/cros-lockscreen-uma Bug: 719015 Change-Id: Id192762e7defeb13be5f77ebf4ec2511bfb693b9 Reviewed-on: https://chromium-review.googlesource.com/719471 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#511568} [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/BUILD.gn [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/login/lock_screen_controller.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/login/ui/lock_screen.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/login/ui/login_password_view_test.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/login/ui/note_action_launch_button.cc [add] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/metrics/login_metrics_recorder.cc [add] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/metrics/login_metrics_recorder.h [add] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/metrics/login_metrics_recorder_unittest.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/metrics/user_metrics_recorder.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/metrics/user_metrics_recorder.h [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/shelf/login_shelf_view.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/system/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/system/tray/system_tray.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/system/virtual_keyboard/virtual_keyboard_tray.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/ash/system/web_notification/web_notification_tray.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/testing/buildbot/filters/ash_unittests_mash.filter [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/tools/metrics/histograms/enums.xml [modify] https://crrev.com/e0e01a5322dbbd37395a85e4922231cd88067f03/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a309db51919b6e0159dd72214d6f5510a93a3283 commit a309db51919b6e0159dd72214d6f5510a93a3283 Author: Jacob Dufault <jdufault@google.com> Date: Sat Nov 04 00:32:52 2017 cros: Enable views-based lock by default. Bug: 719015 Change-Id: I83b9207720d0166b69058c67a63e57d0ada69527 Reviewed-on: https://chromium-review.googlesource.com/726240 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#513987} [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/lock_screen_action/lock_screen_action_background_controller.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/login/ui/login_test_base.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/login/ui/login_test_base.h [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/public/cpp/ash_switches.h [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/root_window_controller.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/shelf/shelf_widget.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/a309db51919b6e0159dd72214d6f5510a93a3283/testing/buildbot/filters/ash_unittests_mash.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0b20839b6827d2ce7a156baf9f480695932ea8b commit d0b20839b6827d2ce7a156baf9f480695932ea8b Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Nov 06 20:43:47 2017 Revert "cros: Enable views-based lock by default." This reverts commit a309db51919b6e0159dd72214d6f5510a93a3283. Reason for revert: amd64-generic and betty VM Tests are failing (https://bugs.chromium.org/p/chromium/issues/detail?id=781845) Original change's description: > cros: Enable views-based lock by default. > > Bug: 719015 > Change-Id: I83b9207720d0166b69058c67a63e57d0ada69527 > Reviewed-on: https://chromium-review.googlesource.com/726240 > Commit-Queue: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#513987} TBR=jamescook@chromium.org,xiyuan@chromium.org,jdufault@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 719015 Change-Id: I6be5ec041d823a02d87d29fdd4e6c7ba85799c4f Reviewed-on: https://chromium-review.googlesource.com/755333 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#514236} [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/lock_screen_action/lock_screen_action_background_controller.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/login/ui/login_test_base.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/login/ui/login_test_base.h [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/public/cpp/ash_switches.h [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/root_window_controller.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/shelf/shelf_widget.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/d0b20839b6827d2ce7a156baf9f480695932ea8b/testing/buildbot/filters/ash_unittests_mash.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3da8b1ad1c5ddf7b3fe60be0704f14652d690638 commit 3da8b1ad1c5ddf7b3fe60be0704f14652d690638 Author: Jacob Dufault <jdufault@google.com> Date: Tue Nov 07 23:56:50 2017 cros: Remove unused background bounds in LoginDisplay. Bug: 719015 Change-Id: If79236ba8609956e699de6bf19ee1d8abe117119 Reviewed-on: https://chromium-review.googlesource.com/752065 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#514661} [modify] https://crrev.com/3da8b1ad1c5ddf7b3fe60be0704f14652d690638/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [modify] https://crrev.com/3da8b1ad1c5ddf7b3fe60be0704f14652d690638/chrome/browser/chromeos/login/ui/login_display.cc [modify] https://crrev.com/3da8b1ad1c5ddf7b3fe60be0704f14652d690638/chrome/browser/chromeos/login/ui/login_display.h [modify] https://crrev.com/3da8b1ad1c5ddf7b3fe60be0704f14652d690638/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/3da8b1ad1c5ddf7b3fe60be0704f14652d690638/chrome/browser/chromeos/login/ui/mock_login_display.cc [modify] https://crrev.com/3da8b1ad1c5ddf7b3fe60be0704f14652d690638/chrome/browser/chromeos/login/ui/webui_login_display.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53 commit 1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53 Author: Jacob Dufault <jdufault@google.com> Date: Fri Nov 10 00:42:30 2017 cros: Rename LoginDisplayHostImpl to LoginDisplayHostWebUI Impl is not specific, and since there are going to be two separate implementations it would be better to call it out explicitly. NOPRESUBMIT=true Bug: 719015 Change-Id: Ief5e75c6d00f99366f8ed49a99fcf76ec87fbe1d Reviewed-on: https://chromium-review.googlesource.com/752076 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#515375} [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/active_directory_login_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/app_launch_controller.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/login_manager_test.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/oobe_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/reset_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/saml/saml_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/supervised/supervised_user_creation_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/supervised/supervised_user_login_flow.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/supervised/supervised_user_password_browsertest.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/supervised/supervised_user_test_base.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/test/oobe_base_test.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/test/oobe_base_test.h [rename] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/ui/login_display_host_webui.cc [rename] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/ui/login_display_host_webui.h [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/ui/user_adding_screen.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/login/ui/webui_login_view.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/components/keep_alive_registry/keep_alive_types.cc [modify] https://crrev.com/1c71f8bfb70b2e9dd71e8fb699f96a76bca00a53/components/keep_alive_registry/keep_alive_types.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f141de4c06230c12ef792a1659afbff010a27aa4 commit f141de4c06230c12ef792a1659afbff010a27aa4 Author: Wenzhao Zang <wzang@chromium.org> Date: Fri Nov 10 06:20:15 2017 Add interface to set letter-spacing and placeholder font in Textfield 1) We need larger bullets, which is essentially the same with setting different sizes (or FontList) for the bullets and placeholder. 2) We need letter spacing, which can be done by making the line advance more each time in |RenderTextHarfBuzz::ShapeRunWithFont|. Bug: 719015 Change-Id: Ie5370e44d767e54264fa2e4ccb02a481063558da Reviewed-on: https://chromium-review.googlesource.com/732526 Reviewed-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#515470} [modify] https://crrev.com/f141de4c06230c12ef792a1659afbff010a27aa4/ash/login/ui/login_password_view.cc [modify] https://crrev.com/f141de4c06230c12ef792a1659afbff010a27aa4/ui/gfx/render_text.h [modify] https://crrev.com/f141de4c06230c12ef792a1659afbff010a27aa4/ui/gfx/render_text_harfbuzz.cc [modify] https://crrev.com/f141de4c06230c12ef792a1659afbff010a27aa4/ui/gfx/render_text_unittest.cc [modify] https://crrev.com/f141de4c06230c12ef792a1659afbff010a27aa4/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/f141de4c06230c12ef792a1659afbff010a27aa4/ui/views/controls/textfield/textfield.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79021b8b1dcc08fa8f9513bfd137f987494d3b8d commit 79021b8b1dcc08fa8f9513bfd137f987494d3b8d Author: Jacob Dufault <jdufault@google.com> Date: Sat Nov 11 02:02:17 2017 Reland cros: Enable views-based lock by default. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/726240, which was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/755333. TBR=jamescook@ TBR=xiyuan@ Bug: 719015 Change-Id: I55c770dcdeb338f43ad409d502aa27c80f4e65eb Reviewed-on: https://chromium-review.googlesource.com/764400 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#515794} [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/lock_screen_action/lock_screen_action_background_controller.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/login/ui/login_test_base.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/login/ui/login_test_base.h [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/public/cpp/ash_switches.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/public/cpp/ash_switches.h [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/root_window_controller.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/shelf/shelf_widget.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/ash/system/status_area_widget_unittest.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/chromeos/lock_screen_apps/note_taking_browsertest.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/chromeos/lock_screen_apps/state_controller.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/chromeos/lock_screen_apps/state_controller_unittest.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/chromeos/login/chrome_restart_request.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/chromeos/login/lock/screen_locker.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/chromeos/shutdown_policy_browsertest.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/79021b8b1dcc08fa8f9513bfd137f987494d3b8d/testing/buildbot/filters/ash_unittests_mash.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fbed9c01598b98082b48b2b8fcf3d2b6b11d91d commit 0fbed9c01598b98082b48b2b8fcf3d2b6b11d91d Author: Jacob Dufault <jdufault@google.com> Date: Tue Nov 14 19:22:24 2017 cros: Add delayed auth fail option in login/lock dev overlay. Bug: 719015 Change-Id: I0b937317d18ed04bbc3faf28dbb7ebcc77093988 Reviewed-on: https://chromium-review.googlesource.com/767023 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#516382} [modify] https://crrev.com/0fbed9c01598b98082b48b2b8fcf3d2b6b11d91d/ash/login/lock_screen_controller.cc [modify] https://crrev.com/0fbed9c01598b98082b48b2b8fcf3d2b6b11d91d/ash/login/lock_screen_controller.h [modify] https://crrev.com/0fbed9c01598b98082b48b2b8fcf3d2b6b11d91d/ash/login/ui/lock_debug_view.cc [modify] https://crrev.com/0fbed9c01598b98082b48b2b8fcf3d2b6b11d91d/ash/login/ui/lock_debug_view.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b7a2d848a0cb3db536debc26d7d5540196aca27d commit b7a2d848a0cb3db536debc26d7d5540196aca27d Author: Jacob Dufault <jdufault@google.com> Date: Fri Dec 01 23:21:15 2017 cros: Dedup concurrent auth attempts on views-based lock screen. If there are concurrent attempts (ie, spamming spacebar and enter) lock would get into a bad state. Prevent concurrent attempts. Bug: 719015 Change-Id: I4e40368fc8daa1d6ba3c47d4d181a0331b29d2a2 Reviewed-on: https://chromium-review.googlesource.com/688734 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521111} [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/login_screen_controller.cc [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/login_screen_controller.h [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/login_screen_controller_unittest.cc [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/mock_login_screen_client.cc [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/mock_login_screen_client.h [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/ui/lock_screen_sanity_unittest.cc [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/ui/login_auth_user_view.h [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/ui/login_password_view.cc [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/ui/login_password_view.h [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/ash/login/ui/login_password_view_test.cc [modify] https://crrev.com/b7a2d848a0cb3db536debc26d7d5540196aca27d/testing/buildbot/filters/ash_unittests_mash.filter
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dab55572c749c63ec506b20745c590f9cf7e1ba commit 9dab55572c749c63ec506b20745c590f9cf7e1ba Author: Jacob Dufault <jdufault@google.com> Date: Sat Dec 02 01:34:26 2017 Fire an accessibility change event in Button::SetAccessibleName. This allows a consumer to call SetAccessibleName multiple times and have the new name be reflected in ChromeVox. Bug: 719015 Change-Id: If355c3988907f67f336255a9b146e742e44bf9e2 Reviewed-on: https://chromium-review.googlesource.com/709921 Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#521172} [modify] https://crrev.com/9dab55572c749c63ec506b20745c590f9cf7e1ba/ui/views/controls/button/button.cc
Comment 1 by jamescook@chromium.org
, May 8 2017