New issue
Advanced search Search tips

Issue 719009 link

Starred by 2 users
Status: Fixed
Owner:
pfeldman@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: report adding mutation event listener as a violation.

Project Member Reported by pfeldman@chromium.org, May 5 2017 
Following event handlers affect page performance and hence need to be reported as discouraged:

    "DOMCharacterDataModified",
    "DOMNodeInserted",
    "DOMNodeInsertedIntoDocument",
    "DOMNodeRemoved",
    "DOMNodeRemovedFromDocument",
    "DOMSubtreeModified"
Project Member

Comment 1 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9913fd894e029450864bbc1962290b0b76f2300e

commit 9913fd894e029450864bbc1962290b0b76f2300e
Author: pfeldman <pfeldman@chromium.org>
Date: Wed May 10 21:45:39 2017

DevTools: report adding mutation event listener as a violations.

BUG= 719009 
NOTRY=true

Review-Url: https://codereview.chromium.org/2863183003
Cr-Commit-Position: refs/heads/master@{#470721}

[add] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/LayoutTests/inspector-protocol/console/console-dom-mutation-violations-expected.txt
[add] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/LayoutTests/inspector-protocol/console/console-dom-mutation-violations.html
[modify] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/Source/core/events/EventTarget.cpp
[modify] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/Source/core/events/EventUtil.cpp
[modify] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/Source/core/events/EventUtil.h
[modify] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/Source/core/frame/PerformanceMonitor.cpp
[modify] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp
[modify] https://crrev.com/9913fd894e029450864bbc1962290b0b76f2300e/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js

Comment 2 by pfeldman@chromium.org, Oct 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment