New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718974 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 701032



Sign in to add a comment

[Sync] Switch ModelTypeStore* from blocking pool to post_task.h

Project Member Reported by s...@chromium.org, May 5 2017

Issue description

Right now new model types cannot follow the instructions listed at https://cs.chromium.org/chromium/src/components/sync/model/model_type_store.h?l=138 when trying to create new stores. This is because BrowserThread::GetBlockingPool() is now a banned function. We need to move over to using the equivalent form post_task.h, such as https://cs.chromium.org/chromium/src/base/task_scheduler/post_task.h?q=post_Task.h&l=191

Unfortunately, the concept of a named sequence token is going away, and we're going to need to create some mapping ourselves to track which task runner should be used for each profile/path.
 

Comment 1 by s...@chromium.org, May 5 2017

Blocking: 701032
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7991ed9aaa1c6c0ff7faf13153503aa5819efa31

commit 7991ed9aaa1c6c0ff7faf13153503aa5819efa31
Author: skym <skym@chromium.org>
Date: Tue May 09 15:00:49 2017

[Sync] Switch ModelTypeStore* from blocking pool to post_task.h

BUG= 718974 

Review-Url: https://codereview.chromium.org/2863173002
Cr-Commit-Position: refs/heads/master@{#470334}

[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/chrome/browser/chromeos/printing/printers_manager_factory.cc
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/components/sync/model/model_type_store.cc
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/components/sync/model/model_type_store.h
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/components/sync/model_impl/model_type_store_backend.cc
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/components/sync/model_impl/model_type_store_impl.cc
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/components/sync/model_impl/model_type_store_impl.h
[modify] https://crrev.com/7991ed9aaa1c6c0ff7faf13153503aa5819efa31/ios/chrome/browser/reading_list/reading_list_model_factory.cc

Comment 3 by s...@chromium.org, May 11 2017

Status: Fixed (was: Started)

Sign in to add a comment