SingleSampleMetricsFactoryImplTest.MultithreadedMetrics is flaky |
|||
Issue descriptionAccording to Findit's analysis at https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKPAWNocm9taXVtLmxpbnV4L0FuZHJvaWQgVGVzdHMvNDEzNTUvY29tcG9uZW50c191bml0dGVzdHMgb24gQW5kcm9pZC9VMmx1WjJ4bFUyRnRjR3hsVFdWMGNtbGpjMFpoWTNSdmNubEpiWEJzVkdWemRDNU5kV3gwYVhSb2NtVmhaR1ZrVFdWMGNtbGpjdz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw The cl https://codereview.chromium.org/2687583002 introduced a new test found to be flaky from the get-go
,
May 15 2017
,
May 15 2017
Yeah, seems correct since that CL introduced the test :) Will take a look. Thanks!
,
May 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a692b66c652e1e0fd2446f469093ee3e5d81539d commit a692b66c652e1e0fd2446f469093ee3e5d81539d Author: dalecurtis <dalecurtis@chromium.org> Date: Fri May 19 01:42:50 2017 Fix flakiness in MultithreadedMetrics test for single sample metrics. Metric shutdown ends up posting a few tasks for which our simple DoNothing trampoline was insufficient to ensure they completed. Instead shutdown the thread since we don't need it anymore anyways; this waits for all posted tasks to complete. BUG= 718973 TEST=ran android test 25 times without failure, failed immediately prior to this fix. Review-Url: https://codereview.chromium.org/2894553004 Cr-Commit-Position: refs/heads/master@{#473023} [modify] https://crrev.com/a692b66c652e1e0fd2446f469093ee3e5d81539d/components/metrics/single_sample_metrics_factory_impl_unittest.cc
,
May 23 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lijeffrey@chromium.org
, May 5 2017