New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718973 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

SingleSampleMetricsFactoryImplTest.MultithreadedMetrics is flaky

Project Member Reported by lijeffrey@chromium.org, May 5 2017

Issue description

Hi Dale, would you mind helping confirm Findit's results? We're actively trying to improve the flake analyzer to find culprits that cause tests to be flaky, so if this is a false positive or noise feel free to close.

Thanks,
Jeff on behalf of Findit team
Cc: dalecur...@chromium.org
 Issue 719497  has been merged into this issue.
Cc: -dalecur...@chromium.org
Labels: -Pri-3 M-60 OS-All Pri-1
Status: Assigned (was: Untriaged)
Yeah, seems correct since that CL introduced the test :) Will take a look. Thanks!
Project Member

Comment 4 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a692b66c652e1e0fd2446f469093ee3e5d81539d

commit a692b66c652e1e0fd2446f469093ee3e5d81539d
Author: dalecurtis <dalecurtis@chromium.org>
Date: Fri May 19 01:42:50 2017

Fix flakiness in MultithreadedMetrics test for single sample metrics.

Metric shutdown ends up posting a few tasks for which our simple
DoNothing trampoline was insufficient to ensure they completed.
Instead shutdown the thread since we don't need it anymore anyways;
this waits for all posted tasks to complete.

BUG= 718973 
TEST=ran android test 25 times without failure, failed immediately
prior to this fix.

Review-Url: https://codereview.chromium.org/2894553004
Cr-Commit-Position: refs/heads/master@{#473023}

[modify] https://crrev.com/a692b66c652e1e0fd2446f469093ee3e5d81539d/components/metrics/single_sample_metrics_factory_impl_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment