New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718972 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Sync: deprecate PAGE_TRANSITION_CHAIN qualifiers

Project Member Reported by pnoland@chromium.org, May 5 2017

Issue description

Currently,  PAGE_TRANSITION_CHAIN_(START|END) qualifiers are set in the history backend, after sync sees the navigation, so sync always sees the value as false. 
 
Now that I think about it, I'm not sure it makes any sense to record these. Sync doesn't record each component of the redirect chain as a separate entry; instead it stores the entire chain in the navigation_redirect field:
https://cs.chromium.org/chromium/src/components/sync/protocol/session_specifics.proto?l=143

This means the qualifiers aren't meaningful; every synced navigation is both the start and end of a chain, since it always encompasses the entire chain.

Instead, I think we should just remove the qualifiers entirely. If someone is interested in whether or not there were redirects, they can check the size of the navigation_redirect field. Nicolas, any thoughts?

Comment 2 by zea@chromium.org, May 9 2017

So, redirects will be captured by the redirect_type field, correct? Yeah, in that case we're already encoding chain start and end in a sequence of navigations. We should probably just deprecate these two fields.
FWIW, redirect_type seems to only be populated for client redirects from my ad-hoc testing. It's also a singular value, whereas the chain is of arbitrary length. 

Digging into the context for why navigation_redirect was added in the first place, I think if we wanted to augment redirect data, we'd want to add additional fields to navigation_redirect specifying each redirect_type and status code as opposed to populating singular fields for the navigation entry.  

I will re-purpose this bug to be for deprecating these fields. 
Summary: Sync: deprecate PAGE_TRANSITION_CHAIN qualifiers (was: Sync should correctly record PAGE_TRANSITION_CHAIN qualifiers)
Status: WontFix (was: Assigned)

Sign in to add a comment