New issue
Advanced search Search tips

Issue 718968 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix up comments in WebAudio to match code

Project Member Reported by rtoy@chromium.org, May 5 2017

Issue description

In The Great Blink Rename, many things were renamed, but the corresponding comments were not touched.  We need to update the comments to match the code.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ed35784e883877394fb71901f3579749d8c05a9

commit 6ed35784e883877394fb71901f3579749d8c05a9
Author: rtoy <rtoy@chromium.org>
Date: Thu May 11 15:18:35 2017

Fix comments to match code in AudioNode.h

No functional changes.

BUG= 718968 
TEST=none

Review-Url: https://codereview.chromium.org/2871953003
Cr-Commit-Position: refs/heads/master@{#470960}

[modify] https://crrev.com/6ed35784e883877394fb71901f3579749d8c05a9/third_party/WebKit/Source/modules/webaudio/AudioNode.h

@rtoy, I'm interesting in this work.
Can you let me complete?

I have some question.

1. Should capitalized function names are fixed in comments? eg. pullInputs() -> PullInputs()
2. Is it enough fixing under webaudio folder or not?
I think there is a couple of things around this issue:

1. Variable names: m_foo -> |foo_|
2. Method names: fooBar() -> |FooBar()|
3. We manage both modules/audio and platform/audio.

Thanks for your interest and let me know if you have more questions!
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 9

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Closing (WontFix, obsolete)

File new separate bugs if and when the comments are updated.

Sign in to add a comment