New issue
Advanced search Search tips

Issue 718967 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename Distance.* to DistanceEffect.*

Project Member Reported by rtoy@chromium.org, May 5 2017 
The files Distance.* implements the class DistanceEffect.  We should rename the files to match the actual class name.
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27ea3538fa4f74eef95f7f53834231aa6c0892c9

commit 27ea3538fa4f74eef95f7f53834231aa6c0892c9
Author: rtoy <rtoy@chromium.org>
Date: Tue May 09 19:13:33 2017

Rename Distance.* file to DistanceEffect.*

The class is named DistanceEffect, but the implementation is in the
files Distance.{h,cpp}.  Rename the file to match the class name.

No other changes.

BUG= 718967 
TEST=no changes to tests

Review-Url: https://codereview.chromium.org/2864383002
Cr-Commit-Position: refs/heads/master@{#470401}

[modify] https://crrev.com/27ea3538fa4f74eef95f7f53834231aa6c0892c9/third_party/WebKit/Source/modules/webaudio/PannerNode.h
[modify] https://crrev.com/27ea3538fa4f74eef95f7f53834231aa6c0892c9/third_party/WebKit/Source/platform/BUILD.gn
[rename] https://crrev.com/27ea3538fa4f74eef95f7f53834231aa6c0892c9/third_party/WebKit/Source/platform/audio/DistanceEffect.cpp
[rename] https://crrev.com/27ea3538fa4f74eef95f7f53834231aa6c0892c9/third_party/WebKit/Source/platform/audio/DistanceEffect.h

Comment 2 by rtoy@chromium.org, May 10 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment