New issue
Advanced search Search tips

Issue 718932 link

Starred by 3 users
Status: Fixed
Owner:
mdjones@chromium.org
Closed: May 2017
Cc:
cl...@chromium.org
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Disable toolbar theme colors for Chrome Home

Project Member Reported by mdjones@chromium.org, May 5 2017 
When the toolbar is at the bottom of the screen, it is detached from the other themed views in Chrome (progress bar, status bar, and site header). Because of this the themed toolbar looks out of place. Theme colors should be disabled in the toolbar while using Chrome Home.
Project Member

Comment 2 by bugdroid1@chromium.org, May 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00e42fce417e8d5875914c16417333b10e73e1e

commit f00e42fce417e8d5875914c16417333b10e73e1e
Author: mdjones <mdjones@chromium.org>
Date: Mon May 08 19:53:54 2017

[Home] Disable theme colors in toolbar

This change disabled theme colors in the toolbar when Chrome Home is
enabled. The primary mechanism for doing this overriding functionality
in the ToolbarDataProvider to always return a default theme color.
Since theme colors are still needed for the status and progress bars,
the tab still needs to retain knowledge of the web contents' theme.
In those cases, the tab is queried instead of the data provider (this
should be cleaned up once a decision is made to keep or remove
themes).

BUG= 718932 

Review-Url: https://codereview.chromium.org/2862113003
Cr-Commit-Position: refs/heads/master@{#470087}

[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerDocument.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/ToolbarSwipeLayout.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/phone/StackLayout.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/TabListSceneLayer.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/compositor/scene_layer/ToolbarSceneLayer.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/BottomToolbarPhone.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/f00e42fce417e8d5875914c16417333b10e73e1e/chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java

Comment 3 by mdjones@chromium.org, May 8 2017

Status: Fixed (was: Assigned)

Comment 4 Deleted

►

Sign in to add a comment