New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718920 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

7.9% regression in system_health.memory_mobile at 469323:469353

Project Member Reported by kraynov@chromium.org, May 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=718920

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDgisvNrQoM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Cc: rmcilroy@chromium.org
Owner: rmcilroy@chromium.org

=== Auto-CCing suspected CL author rmcilroy@chromium.org ===

Hi rmcilroy@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ross McIlroy
  Commit : 662aa425bac00f468d2b2e91a149b5f35e2a4ad3
  Date   : Thu May 04 11:21:59 2017
  Subject: Reland: [TypeFeedbackVector] Store optimized code in the vector

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_search/load_search_baidu
  Change       : 6.85% | 3762193.33333 -> 4019938.66667

Revision                           Result                  N
chromium@469322                    3762193 +- 22941.6      9      good
chromium@469338                    3762337 +- 24843.3      9      good
chromium@469338,v8@0733add072      3758749 +- 21102.5      9      good
chromium@469338,v8@24d7890151      3786605 +- 257059       9      good
chromium@469338,v8@662aa425ba      4027078 +- 295915       9      bad       <--
chromium@469339                    4054601 +- 19395.0      6      bad
chromium@469340                    4054655 +- 19657.9      6      bad
chromium@469342                    4054667 +- 19847.5      6      bad
chromium@469346                    4054675 +- 19834.7      6      bad
chromium@469353                    4019939 +- 283305       9      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.baidu system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980420775289413072

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=4939017797238784


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Ross McIlroy
  Commit : 662aa425bac00f468d2b2e91a149b5f35e2a4ad3
  Date   : Thu May 04 11:21:59 2017
  Subject: Reland: [TypeFeedbackVector] Store optimized code in the vector

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:v8:effective_size_avg/load_search/load_search_baidu
  Change       : 7.81% | 3755692.0 -> 4049005.33333

Revision                           Result                  N
chromium@469322                    3755692 +- 1608.36      6       good
chromium@469338                    3760499 +- 21419.3      9       good
chromium@469338,v8@0733add072      3758311 +- 11693.8      6       good
chromium@469338,v8@24d7890151      3758103 +- 16864.9      6       good
chromium@469338,v8@662aa425ba      4060478 +- 19825.3      6       bad       <--
chromium@469339                    4054649 +- 19599.2      6       bad
chromium@469340                    4051875 +- 15586.8      6       bad
chromium@469342                    4012752 +- 398764       14      bad
chromium@469346                    4058581 +- 25618.5      9       bad
chromium@469353                    4049005 +- 154.471      6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.search.baidu system_health.memory_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980420766977132240

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6414126194098176


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 719463  has been merged into this issue.
 Issue 719463  has been merged into this issue.
 Issue 719463  has been merged into this issue.
Status: Fixed (was: Untriaged)
This CL got reverted for other reasons. I'll have a look at this before relanding. 

Sign in to add a comment