Issue 718916 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	sorin@chromium.org
Closed:	May 2017
Components:	Internals>Installer>Components
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

refactor windows dependency out of UpdaterState class

Project Member Reported by sorin@chromium.org, May 5 2017

Issue description

The current class definion of UpdaterState contains a
Windows specific declaration for UpdaterState::GetUpdaterTimeValue.

This dependency is undesirable and can be avoided by moving the declaration
of this function to its compilation unit.

Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0a5a62f736a57278092edbf232f61d68394b02e

commit a0a5a62f736a57278092edbf232f61d68394b02e
Author: sorin <sorin@chromium.org>
Date: Fri May 05 17:08:02 2017

Refactor windows dependency out of UpdaterState class;

BUG= 718916 

Review-Url: https://codereview.chromium.org/2863993003
Cr-Commit-Position: refs/heads/master@{#469689}

[modify] https://crrev.com/a0a5a62f736a57278092edbf232f61d68394b02e/components/update_client/updater_state.h
[modify] https://crrev.com/a0a5a62f736a57278092edbf232f61d68394b02e/components/update_client/updater_state_win.cc

Comment 2 by sorin@chromium.org, May 16 2017

Status: Fixed (was: Started)

►

Issue 718916 link

Issue metadata

refactor windows dependency out of UpdaterState class

Issue description

Comment 1 by bugdroid1@chromium.org, May 5 2017

Comment 1 Deleted

Comment 2 by sorin@chromium.org, May 16 2017

Comment 2 Deleted

Sign in to add a comment