New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718910 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

10.3% regression in system_health.common_mobile at 469309:469338

Project Member Reported by kraynov@chromium.org, May 5 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=718910

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg8q-3oAsM


Bot(s) for this bug's original alert(s):

android-nexus5
Cc: alexilin@chromium.org
Owner: alexilin@chromium.org

=== Auto-CCing suspected CL author alexilin@chromium.org ===

Hi alexilin@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : alexilin
  Commit : f89e3e140fa7c28737f493a02e7103ab3946a677
  Date   : Thu May 04 13:10:23 2017
  Subject: predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : system_health.common_mobile
  Metric       : timeToFirstMeaningfulPaint_avg/browse_media/browse_media_facebook_photos
  Change       : 4.81% | 1093.50148958 -> 1146.12079167

Revision             Result                  N
chromium@469308      1093.5 +- 43.6203       6      good
chromium@469316      1073.74 +- 30.9173      6      good
chromium@469317      1153.33 +- 54.1869      6      bad       <--
chromium@469318      1160.25 +- 48.9578      6      bad
chromium@469320      1150.12 +- 17.5212      6      bad
chromium@469323      1164.67 +- 41.3985      6      bad
chromium@469338      1146.12 +- 29.6297      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.facebook.photos system_health.common_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980421637452396224

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5792686973386752


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
Bisect failed for unknown reasons

Please contact the team (see below) and report the error.


Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : system_health.common_mobile
  Metric       : timeToFirstMeaningfulPaint_avg/browse_media/browse_media_facebook_photos


To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.facebook.photos system_health.common_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980421629979049904

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860552959590400


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : alexilin
  Commit : f89e3e140fa7c28737f493a02e7103ab3946a677
  Date   : Thu May 04 13:10:23 2017
  Subject: predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : system_health.common_mobile
  Metric       : timeToFirstMeaningfulPaint_avg/browse_media/browse_media_facebook_photos
  Change       : 5.06% | 1086.66795833 -> 1141.62133333

Revision             Result                  N
chromium@469308      1086.67 +- 33.5352      6      good
chromium@469316      1055.08 +- 37.57        6      good
chromium@469317      1155.01 +- 45.4159      6      bad       <--
chromium@469318      1142.79 +- 34.8165      6      bad
chromium@469320      1147.9 +- 18.8385       6      bad
chromium@469323      1140.87 +- 12.8384      6      bad
chromium@469338      1141.62 +- 33.2543      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.facebook.photos system_health.common_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980401723788305696

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5860552959590400


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
 Issue 719469  has been merged into this issue.
 Issue 719469  has been merged into this issue.
Issue 719495 has been merged into this issue.
Project Member

Comment 11 by 42576172...@developer.gserviceaccount.com, May 10 2017

Issue 719495 has been merged into this issue.
Project Member

Comment 13 by 42576172...@developer.gserviceaccount.com, May 10 2017


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : alexilin
  Commit : f89e3e140fa7c28737f493a02e7103ab3946a677
  Date   : Thu May 04 13:10:23 2017
  Subject: predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing.

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : system_health.common_mobile
  Metric       : timeToFirstMeaningfulPaint_avg/browse_media/browse_media_facebook_photos
  Change       : 8.00% | 1071.12877083 -> 1156.81247917

Revision             Result                  N
chromium@469308      1071.13 +- 36.8993      6      good
chromium@469316      1075.95 +- 37.5516      6      good
chromium@469317      1165.72 +- 30.679       6      bad       <--
chromium@469318      1143.24 +- 20.3621      6      bad
chromium@469320      1160.81 +- 32.7326      6      bad
chromium@469323      1166.42 +- 39.1604      6      bad
chromium@469338      1156.81 +- 32.1708      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.facebook.photos system_health.common_mobile

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8979970373025400032

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=6449109910683648


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Project Member

Comment 14 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02b1d73344512180911bc5280438b840dd5105c8

commit 02b1d73344512180911bc5280438b840dd5105c8
Author: alexilin <alexilin@chromium.org>
Date: Thu May 11 11:33:18 2017

Revert of predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing. (patchset #2 id:20001 of https://codereview.chromium.org/2856893004/ )

Reason for revert:
SpeculativePrefetching causes regressions for those tests that are forced to load all resources from the network.

Original issue's description:
> predictors: Enable SpeculativeResourcePrefetching for fieldtrial testing.
>
> BUG=631966
>
> Review-Url: https://codereview.chromium.org/2856893004
> Cr-Commit-Position: refs/heads/master@{#469317}
> Committed: https://chromium.googlesource.com/chromium/src/+/f89e3e140fa7c28737f493a02e7103ab3946a677

TBR=jwd@chromium.org,pasko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=631966, 718910 

Review-Url: https://codereview.chromium.org/2872303004
Cr-Commit-Position: refs/heads/master@{#470918}

[modify] https://crrev.com/02b1d73344512180911bc5280438b840dd5105c8/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Untriaged)
Perf testing for SpeculativeResourcePrefetching was disabled. It's still experimental. If we launch the feature, we need to figure out how to integrate it correctly with perf tests.
The right way would be purge predictor database along with the cache.

Sign in to add a comment