New issue
Advanced search Search tips

Issue 718895 link

Starred by 2 users
Status: Assigned
Owner:
est...@chromium.org
Cc:
rch@chromium.org
est...@chromium.org
mattm@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Expect-CT header: missing test for QUIC ProofVerifierChromium

Project Member Reported by est...@chromium.org, May 5 2017 
https://codereview.chromium.org/2850033002/ is landing with a test missing for the ProofVerifierChromium change. It should have ProofVerifierChromium tests corresponding to the SSLClientSocketImpl tests, but almost all the ProofVerifierChromium tests are disabled at the moment and we're not sure why.

rch: I'm assigning this to you for the moment while you're investigating. Please assign back to me when the mystery is solved and I'll go back and add the test.
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0af6d95f72025aae5c137b54acfcb9b700a66bda

commit 0af6d95f72025aae5c137b54acfcb9b700a66bda
Author: rch <rch@chromium.org>
Date: Tue May 30 20:13:28 2017

Re-enable ProofVerifierChromium tests by generating a signature
dyanmically instead of using the old (and now invalid) signature.

BUG=718895

Review-Url: https://codereview.chromium.org/2908413002
Cr-Commit-Position: refs/heads/master@{#475646}

[modify] https://crrev.com/0af6d95f72025aae5c137b54acfcb9b700a66bda/net/quic/chromium/crypto/proof_verifier_chromium_test.cc

Comment 2 by rch@chromium.org, May 30 2017

Cc: rch@chromium.org
Owner: est...@chromium.org
estark: I've fixed these tests, and un-disabled them. As per your request, I'm assigning this back over to you. But please let me know if I can help with expect-ct-ifying those tests. I
►

Sign in to add a comment