Turn on -Wmicrosoft-enum-forward-reference |
||
Issue description
Fires at least here:
FAILED: obj/remoting/host/win/win/rdp_client.obj
../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/remoting/host/win/win/rdp_client.obj.rsp /c ../../remoting/host/win/rdp_client.cc /Foobj/remoting/host/win/win/rdp_client.obj /Fd"obj/remoting/host/win/win_cc.pdb"
In file included from ../../remoting/host/win/rdp_client.cc:21:
In file included from ../..\remoting/host/win/rdp_client_window.h:21:
C:\b\c\b\ClangToTWin\src\remoting\host\win\com_imported_mstscax.tlh(32,6): error: forward references to 'enum' types are a Microsoft extension [-Werror,-Wmicrosoft-enum-forward-reference]
enum __MIDL___MIDL_itf_mstsax_0000_0037_0001;
^
C:\b\c\b\ClangToTWin\src\remoting\host\win\com_imported_mstscax.tlh(33,6): error: forward references to 'enum' types are a Microsoft extension [-Werror,-Wmicrosoft-enum-forward-reference]
enum __MIDL___MIDL_itf_mstsax_0000_0049_0001;
^
C:\b\c\b\ClangToTWin\src\remoting\host\win\com_imported_mstscax.tlh(34,6): error: forward references to 'enum' types are a Microsoft extension [-Werror,-Wmicrosoft-enum-forward-reference]
enum __MIDL___MIDL_itf_mstsax_0000_0049_0002;
^
Maybe want to disable that for midl headers but enable otherwise, or something.
,
May 5 2017
We could also add the : int suffix to those forward declarations, since that is a checked-in artifact from the midl compiler. Microsoft knows about the problem and should/may fix it at some point.
,
Jun 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a02c1af6db275a166952455d03bdffa7e0bfbf6 commit 2a02c1af6db275a166952455d03bdffa7e0bfbf6 Author: thakis <thakis@chromium.org> Date: Sat Jun 24 01:52:35 2017 clang/win: Enable -Wmicrosoft-enum-forward-reference BUG= 718880 TBR=sergeyu Review-Url: https://codereview.chromium.org/2955643002 Cr-Commit-Position: refs/heads/master@{#482112} [modify] https://crrev.com/2a02c1af6db275a166952455d03bdffa7e0bfbf6/build/config/compiler/BUILD.gn [modify] https://crrev.com/2a02c1af6db275a166952455d03bdffa7e0bfbf6/remoting/host/win/BUILD.gn
,
Jun 24 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, May 5 2017