New issue
Advanced search Search tips

Issue 718878 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

out/Release/gen/components/metrics/proto is 110KiB (4% of Cronet)

Project Member Reported by xunji...@chromium.org, May 5 2017

Issue description

The metrics generated proto is 4% of entire Cronet size.  Many of the protos are not used by Cronet. We should explore whether Cronet can depend on a stripped down version of //components/metrics:metrics






 
cronet_size.zip
1.1 MB Download
screenshot.png
102 KB View Download
The biggest piece here is system_profile.pb.  I wonder if Cronet should be using this when we generate netlogs?  I think it might be quite useful to have more information about the device.
Fixed by https://chromium-review.googlesource.com/c/chromium/src/+/1256122 that allows to optionally remove //components/metrics dependency to reduce binary size.

Add disable_histogram_support gn argument. If set to "true", then GetHistogramDeltas() support is disabled, and Cronet size is reduced by about 200 kilobytes.

Status: Fixed (was: Untriaged)

Sign in to add a comment