New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718850 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task

Blocking:
issue 718007



Sign in to add a comment

DCHECK when loading images that do not exist.

Project Member Reported by jif@chromium.org, May 5 2017

Issue description

We should swizzle [UIImage imageName:] in Canary/Dev so that missing images are caught.
 
Components: Mobile>WebView>Glue
Components: -Mobile>WebView>Glue Internals
Labels: -Type-Bug Type-Task
Project Member

Comment 3 by bugdroid1@chromium.org, May 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b75611794c4ee0538c0f62aaf75abaa409d8963d

commit b75611794c4ee0538c0f62aaf75abaa409d8963d
Author: jif <jif@chromium.org>
Date: Thu May 11 09:22:49 2017

DCHECK when loading images that do not exist.

Enabled only in debug mode.
This works by swizzling [UIImage imageNamed:] and making sure that it returns
a non-nil UIImage*.

BUG= 718850 

Review-Url: https://codereview.chromium.org/2863983002
Cr-Commit-Position: refs/heads/master@{#470887}

[modify] https://crrev.com/b75611794c4ee0538c0f62aaf75abaa409d8963d/ios/chrome/app/startup/setup_debugging.mm

Comment 4 by gab@chromium.org, May 25 2017

Status: Fixed (was: Started)
Scanning DCHECK bugs, this one is fixed?

Sign in to add a comment