New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718839 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

WebRTC ASan bots don't have LSan leak detection enabled

Project Member Reported by kjellander@chromium.org, May 5 2017

Issue description

It seems since we moved over to Swarming for test execution, we lost the leak detection for our ASan bots. machenbach@ tipped me this might be the case since V8 hit a similar problem and with https://codereview.webrtc.org/2868443002/#ps1 I verified it's the case.

After looking at a build I can see that 
ASAN_OPTIONS=symbolize=0
i.e. it's missing the detect_leaks=1 line. 
One way to get that is to use this place where it's added: https://cs.chromium.org/chromium/src/testing/test_env.py?rcl=4d49107dce95a5491acebfab01023a377ae03b58&l=89
We used to pass --lsan=1 to our tests via the recipes when we ran these tests pre-Swarming, but we now use mb.py for generating these command lines.

It seems to be easy to fix though, by just adding a line for LSan here:
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/mb/mb.py#1127
but the Chromium mb.py doesn't have that, so the Chromium bots somehow enable it in another way.

See https://codereview.webrtc.org/2868443002/ 
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/461a560f22a5246f479f861db7178b7546d55b73

commit 461a560f22a5246f479f861db7178b7546d55b73
Author: kjellander <kjellander@webrtc.org>
Date: Fri May 05 13:39:16 2017

Enable LSan leak checking for ASan bots.

We seem to have lost the LSan leak detection when we migrated
our tests to Swarming last year. Too many layers of wrapping scripts
are involved in this

BUG= chromium:718839 
NOTRY=True

Review-Url: https://codereview.webrtc.org/2868443002
Cr-Commit-Position: refs/heads/master@{#18032}

[modify] https://crrev.com/461a560f22a5246f479f861db7178b7546d55b73/tools-webrtc/mb/mb.py
[modify] https://crrev.com/461a560f22a5246f479f861db7178b7546d55b73/tools-webrtc/mb/mb_unittest.py

Cc: machenb...@chromium.org
Status: Fixed (was: Started)
Kudos to machenbach@ for the tip here. Luckily we were running with Valgrind memcheck the whole time so no new leaks sneaked in while this wasn't working.

Sign in to add a comment