Issue metadata
Sign in to add a comment
|
39.9% regression in sizes/libcronet.so on android_cronet_arm64_builder_dbg at 469523:469525 |
||||||||||||||||||||||
Issue descriptionPerformance dashboard identified a 39.9% regression in sizes/libcronet.so on android_cronet_arm64_builder_dbg at revision range 469523:469525. Graph: https://chromeperf.appspot.com/report?masters=ChromiumAndroid&bots=android_cronet_arm64_builder_dbg&tests=sizes%2Flibcronet.so&checked=libcronet.so%2Clibcronet.so_ref%2Cref&rev=469525 https://codereview.chromium.org/2687583002 pulls extra dependency for components/metrics. This results in drastic increases in Cronet binaries. 3.5MB for a debug binary and ~300KB for a release binary.
,
May 5 2017
I started https://codereview.chromium.org/2861153002/. I will send it out for review after I make sure things are still building.
,
May 5 2017
Re #2. While this only has an effect on MIPS release build, I think we should fix it because Cronet consumers do use our debug builds (which increased in size across the board).
,
May 5 2017
How big the increase on non-MIPS release binaries?
,
May 5 2017
No observed effect on non-MIPS release binaries.
,
May 5 2017
I wonder if dead code stripping is enabled for non-MIPS builds that's making only mips get the increase? If so, maybe it should be enabled for mips as well?
,
May 5 2017
Re #6. It might be. Pauljensen@ started a thread to remove MIPS support, so hopefully we won't need to deal with it soon. Our embedders do ship with Cronet debug builds to early testers. If we want to have a reasonable sized debug builds, we should fix it even if this only affects debug. Given that fixing the problem seems trivial (https://codereview.chromium.org/2861153002/), let's just fix it.
,
May 5 2017
sgtm
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a59254424997b8dc543d3d2a3315f707d5c07c79 commit a59254424997b8dc543d3d2a3315f707d5c07c79 Author: xunjieli <xunjieli@chromium.org> Date: Mon May 08 20:01:44 2017 Make single_sample_metrics into its own target This CL makes single_sample_metrics into its own target so consumers who depend on components/metrics can avoid pulling in the dependency if desired. crrev.com/2687583002 increased cronet debug binary size by 40% (3.5MB) and release binary size by 4% (300KB). The effect is not seen on all architectures, but we should try to limit the impact. BUG= 718833 Review-Url: https://codereview.chromium.org/2861153002 Cr-Commit-Position: refs/heads/master@{#470094} [modify] https://crrev.com/a59254424997b8dc543d3d2a3315f707d5c07c79/components/metrics/BUILD.gn [modify] https://crrev.com/a59254424997b8dc543d3d2a3315f707d5c07c79/content/browser/BUILD.gn [modify] https://crrev.com/a59254424997b8dc543d3d2a3315f707d5c07c79/content/browser/DEPS [modify] https://crrev.com/a59254424997b8dc543d3d2a3315f707d5c07c79/content/renderer/BUILD.gn [modify] https://crrev.com/a59254424997b8dc543d3d2a3315f707d5c07c79/content/renderer/DEPS
,
May 8 2017
,
May 9 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pauljensen@chromium.org
, May 5 2017