New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718821 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.4%-147.2% regression in v8.runtimestats.browsing_mobile_classic at 468316:468567

Project Member Reported by verwa...@chromium.org, May 5 2017

Issue description

See the link to graphs below.
 
Cc: rnep...@chromium.org
Owner: rnep...@chromium.org

=== Auto-CCing suspected CL author rnephew@chromium.org ===

Hi rnephew@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : rnephew
  Commit : 0079dbad35b7fb64939a1c5ddc992084cc5001b1
  Date   : Tue May 02 00:45:10 2017
  Subject: Revert of [scheduler] Move some task types to suspendable task runner. (patchset #1 id:1 of https://codereview.chromium.org/2808273003/ )

Bisect Details
  Configuration: android_nexus6_perf_bisect
  Benchmark    : v8.runtimestats.browsing_mobile_classic
  Metric       : V8 C++:duration_avg/browse_chrome/browse_chrome_newtab
  Change       : 148.51% | 1519.36416667 -> 3775.76716667

Revision             Result                  N
chromium@468322      1519.36 +- 42.9501      6      good
chromium@468421      1523.77 +- 19.1504      6      good
chromium@468471      1525.39 +- 85.0851      6      good
chromium@468496      1508.97 +- 38.9099      6      good
chromium@468508      1508.39 +- 35.1441      6      good
chromium@468510      1504.69 +- 25.4512      6      good
chromium@468511      3730.23 +- 34.6203      6      bad       <--
chromium@468514      3742.65 +- 124.938      6      bad
chromium@468520      3775.77 +- 39.0697      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.chrome.newtab v8.runtimestats.browsing_mobile_classic

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8980436143208981600

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5883391129419776


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Cc: kraynov@google.com
 Issue 718874  has been merged into this issue.
 Issue 718808  has been merged into this issue.
Owner: tebbi@chromium.org
Status: Assigned (was: Untriaged)

Comment 7 by tebbi@chromium.org, May 19 2017

Cc: tebbi@chromium.org
Owner: rnep...@chromium.org
Cc: altimin@chromium.org nednguyen@chromium.org
This was reverted because it was causing test failures. I would assume that there is still an effort to land the changes in the original CL in a non-breaking way. Adding altimin@ to confirm that, but I am closing as WontFix for now since chrome not working is worse than a regression.
Status: Wong (was: Assigned)
Yes, this regression is must a side effect from breaking things. I'm trying to reland the patch in question without breaking everything.
Status: WontFix (was: wong)

Sign in to add a comment