New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 718802 link

Starred by 2 users
Status: Fixed
Owner:
vasi...@chromium.org
Closed: May 2017
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ sureshkumari@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Password is misaligned in chrome://md-settings/passwords

Project Member Reported by keerthan...@techmahindra.com, May 5 2017 
Chrome Version:60.0.3090.0
OS:Ubuntu 14.04, Windows

What steps will reproduce the problem?
(1)Launch chrome and save password for any site
(2)Navigate to chrome://md-settings and click on manage passwords
(3)Observe the alignment of password in Saved passwords section

Expected:Password  should not be misaligned
Actual:Password is misaligned

This is a regression issue broken in M-60

Manual Bisect Info:
===================
Good build:60.0.3077.0
Bad build: 60.0.3078.0
PasswordActual.png
8.0 KB View Download
passwordExpected.png
10.5 KB View Download

Comment 1 by kavvaru@chromium.org, May 5 2017

Labels: Proj-MaterialDesign-WebUI OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on Mac 10.12.4 using chrome version 60.0.3090.0

Comment 2 by sureshkumari@chromium.org, May 5 2017

Cc: sureshkumari@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: vasi...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good build:60.0.3077.0 (Revision:466199).
Bad build: 60.0.3078.0 (Revision:466494).
CHANGE-LOG URL:
https://chromium.googlesource.com/chromium/src/+log/9f74925fb7302fe076090d56c4bd3aaa2207e173..7a0ea2253643c495276d4f5953871318f706509a

Review-Url: https://codereview.chromium.org/2805683002
vasilii@ Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thanks.

Comment 3 by ajha@chromium.org, May 5 2017

Labels: ReleaseBlock-Stable
Adding RB-Stable as this is recent regression.

Comment 4 by vasi...@chromium.org, May 5 2017

Status: Started (was: Assigned)
The culprit is correct.
Screenshot from 2017-05-05 19:35:17.png
43.9 KB View Download

Comment 5 by hcarmona@chromium.org, May 5 2017

Cc: hcarmona@chromium.org
 Issue 718262  has been merged into this issue.

Comment 6 by dpa...@chromium.org, May 8 2017

Labels: Hotlist-MD-Settings-PasswordsForms

Comment 7 by vasi...@chromium.org, May 19 2017

Screenshot from 2017-05-19 15:16:33.png
44.1 KB View Download
Project Member

Comment 8 by bugdroid1@chromium.org, May 22 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/124fa61bdad949dc74f5ffb4c59332ca6ab168e7

commit 124fa61bdad949dc74f5ffb4c59332ca6ab168e7
Author: vasilii <vasilii@chromium.org>
Date: Mon May 22 11:50:46 2017

Fix the alignment on chrome://settings/passwords

The problem was in the "more" icon that was made independent from the password column in https://codereview.chromium.org/2805683002 because it produced interesting effects when not enough space for the password.
Now an invisible icon is a part of the header to fix the alignment.

BUG= 718802 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2860423002
Cr-Commit-Position: refs/heads/master@{#473552}

[modify] https://crrev.com/124fa61bdad949dc74f5ffb4c59332ca6ab168e7/chrome/browser/resources/settings/passwords_and_forms_page/password_list_item.html
[modify] https://crrev.com/124fa61bdad949dc74f5ffb4c59332ca6ab168e7/chrome/browser/resources/settings/passwords_and_forms_page/passwords_shared_css.html

Comment 9 by vasi...@chromium.org, May 26 2017

Status: Fixed (was: Started)
Project Member

Comment 10 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, May 26 2017

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-60; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-60 label, otherwise remove Merge-TBD label. Thanks.

Comment 11 by vasi...@chromium.org, May 26 2017

Labels: -Merge-TBD

Comment 12 by msrchandra@chromium.org, May 30 2017

Labels: TE-Verified-M60 TE-Verified-60.0.3112.7
Tested the issue on Chrome Dev# 60.0.3112.7 on Windows, Mac and Linux and found the issue to be fixed. Attaching screen shot for reference.
Hence adding TE-Verified Labels.
Thank You.
718802.png
49.0 KB View Download
►

Sign in to add a comment