New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718770 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 514752
issue 718845
issue 761995



Sign in to add a comment

Clean up after NTPTilesInInstantService launch

Project Member Reported by treib@chromium.org, May 5 2017

Issue description

NTPTilesInInstantService is launching in M60, and enabled by default in M62. The old code paths should be deleted for M63, i.e. after M62 has branched.
 

Comment 1 by treib@chromium.org, May 5 2017

Blockedon: 718845
Labels: -M-61 M-63

Comment 2 by treib@chromium.org, Sep 5 2017

Description: Show this description

Comment 3 by treib@chromium.org, Sep 5 2017

Blockedon: 761995
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b3985e9028faac87216afc54118b75b71288799

commit 7b3985e9028faac87216afc54118b75b71288799
Author: Marc Treib <treib@chromium.org>
Date: Mon Sep 18 11:22:16 2017

Cleanup: Remove feature NTPTilesInInstantService

This was fully launched in M60; time to get rid of the "disabled" code
path.

Bug:  718770 
Change-Id: I5ff017c50ed675e4f8005ffc97b08ebbaba0998c
Reviewed-on: https://chromium-review.googlesource.com/649648
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502552}
[modify] https://crrev.com/7b3985e9028faac87216afc54118b75b71288799/chrome/browser/search/instant_service.cc
[modify] https://crrev.com/7b3985e9028faac87216afc54118b75b71288799/chrome/browser/search/instant_service.h
[modify] https://crrev.com/7b3985e9028faac87216afc54118b75b71288799/chrome/browser/search/instant_service_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb04160f3363b890b502dcc277a577005b3b1911

commit eb04160f3363b890b502dcc277a577005b3b1911
Author: Marc Treib <treib@chromium.org>
Date: Wed Sep 20 11:59:21 2017

Cleanup: Remove server-side suggestion handling in MV iframe

After launching NTPTilesInInstantService, that code path isn't used
anymore.

Bug:  718770 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I26744a514836d379e0adc0fc818c120eaf93e3e1
Reviewed-on: https://chromium-review.googlesource.com/672703
Reviewed-by: Chris Pickel <sfiera@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503116}
[modify] https://crrev.com/eb04160f3363b890b502dcc277a577005b3b1911/chrome/browser/resources/local_ntp/most_visited_single.js

Comment 6 by treib@chromium.org, Sep 20 2017

Status: Fixed (was: Assigned)
I think this can be considered done. There's still cleanup potential in TopSites,  bug 761995 , which is tracked separately.

Sign in to add a comment