New issue
Advanced search Search tips

Issue 718762 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Compat



Sign in to add a comment

PDF file when opened displays a full black page.

Reported by reserveb...@gmail.com, May 5 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36

Example URL:
https://www.rbi.org.in/commonman/English/images/FLW/Know%20Your%20Customer.pdf

Steps to reproduce the problem:
1. Open the PDF file given in the link.
2. The file opened displays full black screen.

What is the expected behavior?
The file should be displayed with its correct content.

What went wrong?
The file can be downloaded and viewed correctly, but the chrome browser does not display it.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 58.0.3029.96  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 25.0 r0
 
Components: Internals>Plugins>PDF
Labels: -Pri-2 Needs-Bisect Needs-Triage-M58 Pri-1
Cc: rbasuvula@chromium.org
Labels: -Needs-Bisect -Needs-Triage-M58 hasbisect-per-revision M-60 OS-Linux OS-Mac
Owner: thestig@chromium.org
Status: Assigned (was: Unconfirmed)
Tested in chrome stable #58.0.3029.96 and canary #60.0.3091.0 on Mac 10.11.6 , Ubuntu 14.04 & Win 10.0 able to reproduce the issue.
Below are the Bisect Details:

Bisect Info:
=============
Good Build: 48.0.2563.0(Revision - 359213)
Bad Build: 48.0.2564.0 (Revision - 359700)

Bisect URL:
=========== 
You are probably looking for a change made after 359461 (known good), but no later than 359469 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/85dce086001825a2faa4e75755a669f5e08a1cad..6ee6e5ef46b8f29612c15f14541c6dd067fbfb10

From the CL above, assigning the issue to the concern owner

@thestig : Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Review-Url:  https://codereview.chromium.org/1436243004
Cc: tsepez@chromium.org och...@chromium.org
https://pdfium.googlesource.com/pdfium.git/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec or https://pdfium.googlesource.com/pdfium.git/+/182d129bcee8f7731b9bbfde0064295ad3b37271 probably tightened the image decoding validation check too much. Will take a look.
It's actually https://pdfium.googlesource.com/pdfium/+/e21fe98d5b5da7da01503b985b07b90c8e811689 which is a reland of 9b99615.
Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/cfd56852b6375d2b4eea473399231caf7dcdbf36

commit cfd56852b6375d2b4eea473399231caf7dcdbf36
Author: Lei Zhang <thestig@chromium.org>
Date: Thu May 18 08:06:10 2017

Fix a situation where images are not properly rendered.

This regressed in commit e21fe98. When the image's bpc is a multiple of
8, there exists a colorspace, and there is a Decode parameter, the image
data source was incorrectly pointing to a data structure that only
contained black pixels.

BUG= chromium:718762 

Change-Id: I5d3fa739e41726b4ed1ebc16465e17f83fff9f8d
Reviewed-on: https://pdfium-review.googlesource.com/5333
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>

[modify] https://crrev.com/cfd56852b6375d2b4eea473399231caf7dcdbf36/core/fpdfapi/render/cpdf_dibsource.cpp
[add] https://crrev.com/cfd56852b6375d2b4eea473399231caf7dcdbf36/testing/resources/pixel/bug_718762.in
[add] https://crrev.com/cfd56852b6375d2b4eea473399231caf7dcdbf36/testing/resources/pixel/bug_718762_expected.pdf.0.png

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, May 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93728be59239103dda2ec95c9a3ea94433f062e1

commit 93728be59239103dda2ec95c9a3ea94433f062e1
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Thu May 18 11:00:15 2017

Roll src/third_party/pdfium/ 46abb66cb..cfd56852b (1 commit)

https://pdfium.googlesource.com/pdfium.git/+log/46abb66cb57d..cfd56852b637

$ git log 46abb66cb..cfd56852b --date=short --no-merges --format='%ad %ae %s'
2017-05-18 thestig Fix a situation where images are not properly rendered.

Created with:
  roll-dep src/third_party/pdfium
BUG= 718762 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I3e20b93248dfe66f696ed8160ec133409e5d15af
Reviewed-on: https://chromium-review.googlesource.com/508472
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#472762}
[modify] https://crrev.com/93728be59239103dda2ec95c9a3ea94433f062e1/DEPS

Labels: TE-Verified-M60 TE-Verified-60.0.3107.4
Tested the issue on windows 7, Mac 10.12.4, Linux Ubuntu 14.04 using chrome version#60.0.3107.4 with the steps mentioned in comment #0.Above URL -PDF content displayed properly without any issue.Hence adding TE-Verified labels.

Please find the attached screen cast for the same.
Thanks!!
718762.mp4
1.9 MB View Download

Sign in to add a comment