Issue metadata
Sign in to add a comment
|
16.4% regression in page_cycler_v2.intl_ja_zh at 468664:468763 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
May 5 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8980445762261815168
,
May 5 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8980445756182455648
,
May 5 2017
=== Auto-CCing suspected CL author scottmg@chromium.org === Hi scottmg@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : scottmg Commit : 6b0131a01da5149cd7acb81973f881a0d85fbe59 Date : Tue May 02 16:34:31 2017 Subject: network service: Plumbing to get URLLoaderFactory to renderer on nav commit Bisect Details Configuration: winx64nvidia_perf_bisect Benchmark : page_cycler_v2.intl_ja_zh Metric : timeToFirstMeaningfulPaint_avg/pcv1-warm/http___hatena.ne.jp_ Change : 16.99% | 43.7344999996 -> 51.1628333343 Revision Result N chromium@468663 43.7345 +- 4.22899 6 good chromium@468670 43.7623 +- 5.3755 6 good chromium@468673 43.0398 +- 3.95492 6 good chromium@468674 45.247 +- 5.60457 6 good chromium@468675 52.077 +- 7.38832 6 bad <-- chromium@468676 49.8763 +- 4.74301 6 bad chromium@468688 51.9507 +- 3.60632 6 bad chromium@468713 54.1185 +- 2.05858 6 bad chromium@468763 51.1628 +- 4.86452 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...hatena.ne.jp. page_cycler_v2.intl_ja_zh Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8980445756182455648 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5859568069902336 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 5 2017
Issue 718756 has been merged into this issue.
,
May 5 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : scottmg Commit : 6b0131a01da5149cd7acb81973f881a0d85fbe59 Date : Tue May 02 16:34:31 2017 Subject: network service: Plumbing to get URLLoaderFactory to renderer on nav commit Bisect Details Configuration: winx64nvidia_perf_bisect Benchmark : page_cycler_v2.intl_ja_zh Metric : timeToFirstMeaningfulPaint_avg/pcv1-warm/http___hatena.ne.jp_ Change : 14.91% | 44.6491666635 -> 51.3073333378 Revision Result N chromium@468663 44.6492 +- 4.43916 6 good chromium@468670 42.9428 +- 6.07744 6 good chromium@468673 44.7783 +- 5.30274 9 good chromium@468674 45.8671 +- 12.3919 9 good chromium@468675 51.2578 +- 4.15747 9 bad <-- chromium@468676 51.4893 +- 3.16485 6 bad chromium@468688 50.9475 +- 4.45393 6 bad chromium@468713 50.9013 +- 4.66418 6 bad chromium@468763 51.3073 +- 3.89614 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http...hatena.ne.jp. page_cycler_v2.intl_ja_zh Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8980445762261815168 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5345467950432256 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
May 5 2017
Issue 718756 has been merged into this issue.
,
May 5 2017
,
May 5 2017
Issue 718881 has been merged into this issue.
,
May 5 2017
Issue 718881 has been merged into this issue.
,
May 5 2017
Issue 718883 has been merged into this issue.
,
May 5 2017
Issue 718890 has been merged into this issue.
,
May 5 2017
Issue 718890 has been merged into this issue.
,
May 5 2017
Issue 718914 has been merged into this issue.
,
May 5 2017
Issue 718914 has been merged into this issue.
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46 commit 9380ddb9f45e2f441d4e6c4daffba47ac4e40e46 Author: jam <jam@chromium.org> Date: Fri May 05 22:51:10 2017 Fix the current per-frame URLLoaderFactory code path. BUG= 712913 , 718757 Review-Url: https://codereview.chromium.org/2864023003 Cr-Commit-Position: refs/heads/master@{#469786} [modify] https://crrev.com/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46/content/child/request_extra_data.cc [modify] https://crrev.com/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46/content/child/request_extra_data.h [modify] https://crrev.com/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46/content/child/web_url_loader_impl.cc [modify] https://crrev.com/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46/content/renderer/render_frame_impl.cc [modify] https://crrev.com/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46/content/renderer/render_frame_impl.h [modify] https://crrev.com/9380ddb9f45e2f441d4e6c4daffba47ac4e40e46/content/renderer/renderer_blink_platform_impl.cc
,
May 8 2017
This should be fixed now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by kraynov@chromium.org
, May 5 2017