New issue
Advanced search Search tips

Issue 718723 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 718724



Sign in to add a comment

nassh: post release notes/changelog to top of console

Project Member Reported by vapier@chromium.org, May 5 2017

Issue description

today the terminal is initialized with content like:
Welcome to Secure Shell (tot) version 0.8.36.2.
Answers to Frequently Asked Questions: https://goo.gl/muppJj (ctrl+click on links to open)

we should add a few more lines there to announce notable new user facing features.  to keep from annoying users, we can show the extended output only like the first X times they run secure shell (where X can be 10 or some other arbitrarily low number).  after that, we can replace it with a single line like:
The ChangeLog/release notes are available at https://goo.gl/YnmXOs

i guess we'll have to forgo translations here since the ChangeLog itself isn't translated, nor is the FAQ for that matter ...
 
Blocking: 718724
Project Member

Comment 2 by bugdroid1@chromium.org, May 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/7977ec0558648b9f8cb430302a2683a734be8478

commit 7977ec0558648b9f8cb430302a2683a734be8478
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed May 17 18:01:53 2017

nassh: support showing release highlights upon startup

Log significant release highlights on startup the first few times.
This way we can easily notify users when there are important (and
possibly breaking) changes.

We'll show these extended details only the first few loads.  After
that, we'll only show the link to the ChangeLog/release notes.

BUG= chromium:718723 

Change-Id: I8945e5d39a58ff2a0599ab8d1afa3e67f61fb7a0
Reviewed-on: https://chromium-review.googlesource.com/503690
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/7977ec0558648b9f8cb430302a2683a734be8478/nassh/concat/release-highlights.txt
[modify] https://crrev.com/7977ec0558648b9f8cb430302a2683a734be8478/nassh/doc/processes.md
[modify] https://crrev.com/7977ec0558648b9f8cb430302a2683a734be8478/nassh/js/nassh_preference_manager.js
[modify] https://crrev.com/7977ec0558648b9f8cb430302a2683a734be8478/nassh/_locales/en/messages.json
[modify] https://crrev.com/7977ec0558648b9f8cb430302a2683a734be8478/nassh/js/nassh_command_instance.js
[modify] https://crrev.com/7977ec0558648b9f8cb430302a2683a734be8478/nassh/concat/nassh_deps.concat

Comment 3 by vapier@chromium.org, May 17 2017

Owner: vapier@chromium.org
Status: Fixed (was: Available)
this will be in 0.8.36.4+
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/apps/libapps/+/48215cccc49a1e8ae6eb6af239c9e89d8eee1f9e

commit 48215cccc49a1e8ae6eb6af239c9e89d8eee1f9e
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 19 18:19:12 2017

nassh: rework release note display conditions

Instead of basing it on version, base it on the contents of the release
notes itself.  This way we can keep adding notes in the dev channel and
they'll show up whenever we update.  Currently, users see it once, and
then not again since the "last release" base is the major stable ver.

We'll cheat and use the size of the notes as a poor man's hash.  It's
unlikely that we'll run into collisions here between two adjacent sets
of notes (since we only remember one value, and we reset it whenever
it changes).

BUG= chromium:718723 

Change-Id: If88054603d6283d2c20d3847ee29bb737d83b03d
Reviewed-on: https://chromium-review.googlesource.com/575692
Reviewed-by: Brandon Gilmore <varz@google.com>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/48215cccc49a1e8ae6eb6af239c9e89d8eee1f9e/nassh/js/nassh_command_instance.js
[modify] https://crrev.com/48215cccc49a1e8ae6eb6af239c9e89d8eee1f9e/nassh/concat/release-highlights.txt

Sign in to add a comment