Issue metadata
Sign in to add a comment
|
fast/css-grid-layout/(grid-align-justify-stretch-with-orthogonal-flows|grid-self-baseline-two-dimensional) fail when run on sharded swarming |
||||||||||||||||||||||
Issue descriptionIt seems that these two tests are consistently failing when running on swarming on Windows when sharded. See - https://build.chromium.org/p/chromium.fyi/builders/WebKit%20Win%20-%20RandomOrder Unexpected Failures: * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal- flows.html * fast/css-grid-layout/grid-self-baseline-two-dimensional.html My current theory is that by running sharding it is revealing some type of brokens?
,
May 5 2017
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f6264df1bd3a73c0f8af49adfc345126eebb1cd commit 7f6264df1bd3a73c0f8af49adfc345126eebb1cd Author: tansell <tansell@chromium.org> Date: Mon May 08 04:56:11 2017 LayoutTests: Disable flaky tests on Windows. These tests are failing a small amount of the time on the Windows Random Order bots now they are running sharded on swarming. The tests affected are; * fast/css-grid-layout/grid-self-baseline-two-dimensional.html * fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html * fast/dnd/dropEffect-for-effectAllowed.html * external/wpt/css/css-ui-3/outline-004.html Bugs have been filed for each of the failing tests. The most likely cause is that they depend on another test being run and the sharding makes this no longer happening. BUG= 717347 , 718717 , 719298 , 719299 NOTRY=true Review-Url: https://codereview.chromium.org/2872463002 Cr-Commit-Position: refs/heads/master@{#469907} [modify] https://crrev.com/7f6264df1bd3a73c0f8af49adfc345126eebb1cd/third_party/WebKit/LayoutTests/TestExpectations
,
May 10 2017
These 2 grid tests also use "ahem" instead of "Ahem" (similar to what happens for outline-004.html see bug #719299 ). I can try a tentative patch to see if this is the actual issue or not.
,
May 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfd0c5e26f717dd1f27c3e17c2f031c30a26951e commit cfd0c5e26f717dd1f27c3e17c2f031c30a26951e Author: rego <rego@igalia.com> Date: Thu May 11 05:11:38 2017 [css-grid] Use "Ahem" instead of "ahem" on grid layout tests This is a tentative fix for an issue we're having on Windows when running tests on random order. BUG= 718717 Review-Url: https://codereview.chromium.org/2869353002 Cr-Commit-Position: refs/heads/master@{#470817} [modify] https://crrev.com/cfd0c5e26f717dd1f27c3e17c2f031c30a26951e/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/cfd0c5e26f717dd1f27c3e17c2f031c30a26951e/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-align-justify-stretch-with-orthogonal-flows.html [modify] https://crrev.com/cfd0c5e26f717dd1f27c3e17c2f031c30a26951e/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-change-alignment-from-stretch.html [modify] https://crrev.com/cfd0c5e26f717dd1f27c3e17c2f031c30a26951e/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-self-baseline-two-dimensional.html
,
May 11 2017
I'll keep an eye on the build today to see if this is really fixed or not, otherwise we should flag again these tests on TestExpectations file.
,
May 11 2017
It seems the buildbot is happy, so I'm closing this for now. Please re-open if the problem appears again. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tansell@chromium.org
, May 5 2017