New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 718715 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"PushPullFIFOSmokeTest/PushPullFIFOSmokeTest.SmokeTests/7" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 5 2017

Issue description

"PushPullFIFOSmokeTest/PushPullFIFOSmokeTest.SmokeTests/7" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQwsSBUZsYWtlIjhQdXNoUHVsbEZJRk9TbW9rZVRlc3QvUHVzaFB1bGxGSUZPU21va2VUZXN0LlNtb2tlVGVzdHMvNww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by olka@chromium.org, May 5 2017

Cc: olka@chromium.org rtoy@chromium.org
Owner: hongchan@chromium.org

Comment 2 by olka@chromium.org, May 5 2017

Status: Assigned (was: Untriaged)
Labels: -Sheriff-Chromium
Components: Blink>WebAudio
Status: Started (was: Assigned)
The huge call count (~8500) actually makes the FIFO clients go over the specified test duration, but the test prematurely stops when that specified duration is reached.

This destroys the child class of FIFOClients first, but the pending task in the task scheduler still triggers the method afterward. At that point, the only thing left is the base class with the pure virtual function. Hence it crashes.
Project Member

Comment 5 by chromium...@appspot.gserviceaccount.com, May 6 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "PushPullFIFOSmokeTest/PushPullFIFOSmokeTest.SmokeTests/7". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQwsSBUZsYWtlIjhQdXNoUHVsbEZJRk9TbW9rZVRlc3QvUHVzaFB1bGxGSUZPU21va2VUZXN0LlNtb2tlVGVzdHMvNww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 6 by olka@chromium.org, May 8 2017

Labels: -Sheriff-Chromium
Project Member

Comment 7 by chromium...@appspot.gserviceaccount.com, May 8 2017

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "PushPullFIFOSmokeTest/PushPullFIFOSmokeTest.SmokeTests/7". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQwsSBUZsYWtlIjhQdXNoUHVsbEZJRk9TbW9rZVRlc3QvUHVzaFB1bGxGSUZPU21va2VUZXN0LlNtb2tlVGVzdHMvNww. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 8 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78e1fd24e94610e1821b0173b5a53302219664fe

commit 78e1fd24e94610e1821b0173b5a53302219664fe
Author: olka <olka@chromium.org>
Date: Mon May 08 12:31:13 2017

Removing PushPullFIFOSmokeTest.SmokeTests/7 (flaky)
Please revert after the test is fixed.

BUG= 718715 

TBR=hongchan@chromium.org

Review-Url: https://codereview.chromium.org/2869733002
Cr-Commit-Position: refs/heads/master@{#469967}

[modify] https://crrev.com/78e1fd24e94610e1821b0173b5a53302219664fe/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp

Comment 9 by olka@chromium.org, May 8 2017

Labels: -Sheriff-Chromium
Project Member

Comment 10 by bugdroid1@chromium.org, May 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7b7263536e2151b952fe4f0884bad4e495da2e0

commit c7b7263536e2151b952fe4f0884bad4e495da2e0
Author: hongchan <hongchan@chromium.org>
Date: Mon May 08 20:15:34 2017

Fix flakiness in PushPullFIFOSmokeTest.SmokeTests/7

This sub-test often crashes because the test runner prematurely starts
tear-down process when the given test duration is up while there are
pending tasks in the thread task scheduler.

Remove the fixed test duration and wait for the actual task/thread to
be completed. Locally confirmed that the test runner waits until tasks
is completed.

BUG= 718715 

Review-Url: https://codereview.chromium.org/2857333006
Cr-Commit-Position: refs/heads/master@{#470101}

[modify] https://crrev.com/c7b7263536e2151b952fe4f0884bad4e495da2e0/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment