Harmony: Internal PageInfo bubble has too much padding on the right |
|||||
Issue descriptionChrome Version : 60.0.3080.5 OS Version: OS X 10.12.4 This would have started in r467031 There's a WIP CL for the Zoom Bubble which needs this too - https://codereview.chromium.org/2845593002/ - but it's got other stuff going on. It's a race to see who lands the delegate method first :)
,
May 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0657b42372a48280879bb16061dcbd258a360814 commit 0657b42372a48280879bb16061dcbd258a360814 Author: tapted <tapted@chromium.org> Date: Mon May 08 07:39:08 2017 Harmony: Don't snap the width of the chrome:// page info bubbles. Adds views::DialogDelegate::ShouldSnapFrameWidth() -> bool to do this. BUG= 718696 , 719274 Review-Url: https://codereview.chromium.org/2863923002 Cr-Commit-Position: refs/heads/master@{#469914} [modify] https://crrev.com/0657b42372a48280879bb16061dcbd258a360814/chrome/browser/ui/views/page_info/page_info_bubble_view.cc [modify] https://crrev.com/0657b42372a48280879bb16061dcbd258a360814/ui/views/bubble/bubble_frame_view.cc [modify] https://crrev.com/0657b42372a48280879bb16061dcbd258a360814/ui/views/bubble/bubble_frame_view_unittest.cc [modify] https://crrev.com/0657b42372a48280879bb16061dcbd258a360814/ui/views/window/dialog_delegate.cc [modify] https://crrev.com/0657b42372a48280879bb16061dcbd258a360814/ui/views/window/dialog_delegate.h
,
May 8 2017
,
May 11 2017
Tested the issue on Latest Dev# 60.0.3095.5 on Windows, Mac and Linux. The issue is found to be fixed on Windows and Linux but on Mac OS X 10.12.4, the issue is still reproducible. Attaching screenshots according. @tapted -- Could you please look into the issue and provide an update. Thank You.
,
May 11 2017
Thanks for looking! This needs Harmony enabled - chrome://flags/#secondary-ui-md Although you are correct that the bubble on Mac without that flag also has too much padding, but that's been the case for a long time - probably not worth fixing, since we're replacing it.
,
May 11 2017
@tapted -- Thanks for the update. As per Comment# 5, Enabled chrome://flags/#secondary-ui-md and checked on Mac OS X. The padding is fine without no extra space. Hence adding TE-Verified labels. Thank You. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by tapted@chromium.org
, May 5 201728.7 KB
28.7 KB View Download