Spec issue [1] and associated commit [2] added landmarks to the detected faces, in particular eyes and mouth. Update the impls to it -- Mac supports it [3], Android only if using GMS core backend [4], or Camera2 live capture [5]). [1] https://github.com/WICG/shape-detection-api/issues/7 [2] https://github.com/WICG/shape-detection-api/commit/dd90bf57313ea3d76b04c1b1c33d44fd5df2d67e [3] https://developer.apple.com/reference/coreimage/cifacefeature [4] https://developers.google.com/android/reference/com/google/android/gms/vision/face/Face [5] https://developer.android.com/reference/android/hardware/camera2/params/Face.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04f35409eaca0779dbe9b8435f20901cf510440b commit 04f35409eaca0779dbe9b8435f20901cf510440b Author: mcasas <mcasas@chromium.org> Date: Sat May 06 00:05:55 2017 Shape Detection: add idl and mojom for face landmarks and wire for Mac Spec issue [1] and associated commit [2] added landmarks to the detected faces, in particular eyes and mouth. This CL: - adds the appropriate idls and mojo definitions to support those; - adapts facedetection mojom Detect() to return an array<structs> ISO a struct{ array<> }, causing a few changes throughout, including on Android impl (which doesn't support landmark detection); - wires detection of said landmarks to Mac Face Detection impl and updates the associated unittests. [1] https://github.com/WICG/shape-detection-api/issues/7 [2] https://github.com/WICG/shape-detection-api/commit/dd90bf57313ea3d76b04c1b1c33d44fd5df2d67e BUG= 718693 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2859413002 Cr-Commit-Position: refs/heads/master@{#469820} [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/content/public/android/java/src/org/chromium/content/browser/shapedetection/FaceDetectionImpl.java [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/services/shape_detection/face_detection_impl_mac.mm [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/services/shape_detection/face_detection_impl_mac_unittest.mm [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/services/shape_detection/public/interfaces/facedetection.mojom [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/Source/modules/modules_idl_files.gni [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/Source/modules/shapedetection/DetectedFace.cpp [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/Source/modules/shapedetection/DetectedFace.h [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/Source/modules/shapedetection/DetectedFace.idl [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp [modify] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/Source/modules/shapedetection/FaceDetector.h [add] https://crrev.com/04f35409eaca0779dbe9b8435f20901cf510440b/third_party/WebKit/Source/modules/shapedetection/Landmark.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f4fc07c75a0a3908059deb0dae280eafa0bb1da commit 7f4fc07c75a0a3908059deb0dae280eafa0bb1da Author: mcasas <mcasas@chromium.org> Date: Wed May 10 15:49:06 2017 Shape Detection: use Google Play services Face detection where available This CL adds support for Face Detection using Google Play Services in FaceDetectionImplGmsCore. FaceDetectionProviderImpl will create a GMSCore detector if and when GMS Core is available, falling back to android.media.FaceDetector otherwise. Also the common code dealing with transforming a SharedBufferHandle into a Frame is moved to SharedBufferUtils.java, convertToFrame(), and the calls sites refactored. BUG= 718693 , 720019 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2868883003 Cr-Commit-Position: refs/heads/master@{#470585} [modify] https://crrev.com/7f4fc07c75a0a3908059deb0dae280eafa0bb1da/services/shape_detection/BUILD.gn [modify] https://crrev.com/7f4fc07c75a0a3908059deb0dae280eafa0bb1da/services/shape_detection/android/java/src/org/chromium/shape_detection/BarcodeDetectionImpl.java [modify] https://crrev.com/7f4fc07c75a0a3908059deb0dae280eafa0bb1da/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java [add] https://crrev.com/7f4fc07c75a0a3908059deb0dae280eafa0bb1da/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java [modify] https://crrev.com/7f4fc07c75a0a3908059deb0dae280eafa0bb1da/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionProviderImpl.java [add] https://crrev.com/7f4fc07c75a0a3908059deb0dae280eafa0bb1da/services/shape_detection/android/java/src/org/chromium/shape_detection/SharedBufferUtils.java [modify] https://crrev.com/7f4fc07c75a0a3908059deb0dae280eafa0bb1da/services/shape_detection/android/java/src/org/chromium/shape_detection/TextDetectionImpl.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc059e074702f77cd815822eb93e6ee954a12bc5 commit fc059e074702f77cd815822eb93e6ee954a12bc5 Author: mcasas <mcasas@chromium.org> Date: Fri May 12 22:59:48 2017 Shape Detection: add SaveSameObject idl to SameObject annotations This CL adds SaveSameObject to the SameObject annotation in idls, following up to comments [1,2]. [1] https://codereview.chromium.org/2859413002/#msg27 [2] https://codereview.chromium.org/2859413002/#msg28 BUG= 718693 TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2873453004 Cr-Commit-Position: refs/heads/master@{#471476} [add] https://crrev.com/fc059e074702f77cd815822eb93e6ee954a12bc5/third_party/WebKit/LayoutTests/shapedetection/detector-same-object.html [modify] https://crrev.com/fc059e074702f77cd815822eb93e6ee954a12bc5/third_party/WebKit/Source/modules/shapedetection/DetectedBarcode.idl [modify] https://crrev.com/fc059e074702f77cd815822eb93e6ee954a12bc5/third_party/WebKit/Source/modules/shapedetection/DetectedFace.h [modify] https://crrev.com/fc059e074702f77cd815822eb93e6ee954a12bc5/third_party/WebKit/Source/modules/shapedetection/DetectedFace.idl [modify] https://crrev.com/fc059e074702f77cd815822eb93e6ee954a12bc5/third_party/WebKit/Source/modules/shapedetection/DetectedText.idl [modify] https://crrev.com/fc059e074702f77cd815822eb93e6ee954a12bc5/third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h
Comment 1 by bugdroid1@chromium.org
, May 6 2017