New issue
Advanced search Search tips

Issue 718689 link

Starred by 3 users

Issue metadata

Status: Duplicate
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug-Regression



Sign in to add a comment

"org.chromium.chrome.browser.history.HistoryActivityTest#testOpenSelectedItems" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 5 2017

Issue description

"org.chromium.chrome.browser.history.HistoryActivityTest#testOpenSelectedItems" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyWAsSBUZsYWtlIk1vcmcuY2hyb21pdW0uY2hyb21lLmJyb3dzZXIuaGlzdG9yeS5IaXN0b3J5QWN0aXZpdHlUZXN0I3Rlc3RPcGVuU2VsZWN0ZWRJdGVtcww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: UI>Browser>History
Labels: -Via-TryFlakes OS-Android
Owner: twelling...@chromium.org
Status: (was: Untriaged)
Labels: -Type-Bug Type-Bug-Regression
It looks like this very recently started flaking, so something must have regressed.

The first try-flake identified is on 04/28.

It appears that the test is timing out waiting for the instrumentation monitor hit: getInstrumentation().checkMonitorHit(activityMonitor, 2);



junit.framework.AssertionFailedError: Criteria not met in allotted time.
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:94)
	at org.chromium.chrome.browser.history.HistoryActivityTest.testOpenSelectedItems(HistoryActivityTest.java:290)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Labels: -Sheriff-Chromium
Status: Assigned
Added the @RetryOnFailure annotation here: https://codereview.chromium.org/2875193003
Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ba15ea49b06f956cabd409d3dfda72b06cbe515

commit 1ba15ea49b06f956cabd409d3dfda72b06cbe515
Author: twellington <twellington@chromium.org>
Date: Fri May 12 17:15:05 2017

Mark HistoryActivityTest#testOpenSelectedItems as @RetryOnFailure

This test started flaking very recently a culprit has not been
identified.

BUG= 718689 
TBR=dfalcantara@chromium.org

Review-Url: https://codereview.chromium.org/2875193003
Cr-Commit-Position: refs/heads/master@{#471347}

[modify] https://crrev.com/1ba15ea49b06f956cabd409d3dfda72b06cbe515/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java

Labels: -Pri-1 Pri-3
Many HistoryActivityTest fail in SetUp:

C  655.750s Main  Detailed Logs
C  655.750s Main  ********************************************************************************
C  655.750s Main  [FAIL] org.chromium.chrome.browser.history.HistoryActivityTest#testOpenItemIntent:
C  655.750s Main  junit.framework.AssertionFailedError: expected:<4> but was:<5>
C  655.750s Main  	at org.chromium.chrome.browser.history.HistoryActivityTest.setUp(HistoryActivityTest.java:150)
C  655.750s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:110)
C  655.750s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  655.750s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  655.750s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  655.750s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  655.750s Main  ********************************************************************************
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70fc047e481b7ed52b74c91fcc58915232726a48

commit 70fc047e481b7ed52b74c91fcc58915232726a48
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Aug 04 13:27:50 2017

Disable some org.chromium.chrome.browser.history.HistoryActivityTest

TBR=twellington@chromium.org

Bug:  718689 
Change-Id: I3c31179a6cd82564d83a940ca54f79b39aff6289
Reviewed-on: https://chromium-review.googlesource.com/602148
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492007}
[modify] https://crrev.com/70fc047e481b7ed52b74c91fcc58915232726a48/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java

Expanding on #7: several HistoryActivityTests have started flaking on Android Tests (dbg) within the last day: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&builder=chromium.linux%3AAndroid%20Tests%20(dbg)
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33d226d53aaa58ca1d02e841a3978a5bbd834119

commit 33d226d53aaa58ca1d02e841a3978a5bbd834119
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Aug 04 14:53:51 2017

Disable flaky org.chromium.chrome.browser.history.HistoryActivityTest#testCopyLink

TBR=twellington@chromium.org

Bug:  718689 
Change-Id: Id935cff5d2b7dbb5479cb6bdbbc7204cc020f108
Reviewed-on: https://chromium-review.googlesource.com/602237
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492028}
[modify] https://crrev.com/33d226d53aaa58ca1d02e841a3978a5bbd834119/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java

Cc: twelling...@chromium.org vasi...@chromium.org
vasilii@ - these new test failures should have been pulled into a separate bug since the stack trace (and therefore the likely root cause) is different. I'm going to split the disabled tests into a separate bug. In the future, please don't re-use bugs for a single flaky test to disable a whole suite.
Cc: -twelling...@chromium.org -vasi...@chromium.org
New bug is issue 752520. Please include any further comments about the new failures in #setup() on that bug.
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf8f706555973f1f8da888192a3f238f90144e7c

commit bf8f706555973f1f8da888192a3f238f90144e7c
Author: Joe Downing <joedow@google.com>
Date: Fri Aug 04 22:12:50 2017

Disable flaky org.chromium.chrome.browser.history.HistoryActivityTest#testRemove_AllItems

TBR=twellington@chromium.org

Bug:  718689 
Change-Id: I7e7ac06830fdce8636279b082929ab3c94324035
Reviewed-on: https://chromium-review.googlesource.com/602393
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492140}
[modify] https://crrev.com/bf8f706555973f1f8da888192a3f238f90144e7c/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java

Project Member

Comment 14 by bugdroid1@chromium.org, Aug 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb818e5e9e6956d6e6eb4b3601c152efa457b43

commit 2eb818e5e9e6956d6e6eb4b3601c152efa457b43
Author: Joe Downing <joedow@chromium.org>
Date: Fri Aug 04 22:30:01 2017

Revert "Disable flaky org.chromium.chrome.browser.history.HistoryActivityTest#testRemove_AllItems"

This reverts commit bf8f706555973f1f8da888192a3f238f90144e7c.

Reason for revert: Area owner has a potential fix in flight.

Original change's description:
> Disable flaky org.chromium.chrome.browser.history.HistoryActivityTest#testRemove_AllItems
> 
> TBR=twellington@chromium.org
> 
> Bug:  718689 
> Change-Id: I7e7ac06830fdce8636279b082929ab3c94324035
> Reviewed-on: https://chromium-review.googlesource.com/602393
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#492140}

TBR=twellington@chromium.org,joedow@chromium.org

Change-Id: I3391b0f5a218d47c85de2582fe7f10a5923d91f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  718689 
Reviewed-on: https://chromium-review.googlesource.com/602618
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#492148}
[modify] https://crrev.com/2eb818e5e9e6956d6e6eb4b3601c152efa457b43/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java

Mergedinto: 752520
Status: Duplicate (was: Assigned)

Sign in to add a comment